From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] bcm43xx: Fix for 4311 and 02/07/07 specification changes
Date: Wed, 14 Feb 2007 00:02:05 +0100 [thread overview]
Message-ID: <200702140002.05727.mb@bu3sch.de> (raw)
In-Reply-To: <45d241c0.gWJcHxUYgWmBTwx8%Larry.Finger@lwfinger.net>
On Tuesday 13 February 2007 23:54, Larry Finger wrote:
> The specifications for the bcm43xx driver have been modified. This patch
> incorporates these changes in the code, which results in the BCM4311 and
> BCM4312 working. The name of one of the PHY parameters, previously known
> as "version", has been changed to "analog", short for "analog core version" .
>
> Signed-off-by: Larry Finger<Larry.Finger@lwfinger.net>
> @@ -750,7 +757,7 @@ static void bcm43xx_phy_initb5(struct bc
> if (radio->version == 0x2050)
> bcm43xx_phy_write(bcm, 0x0038, 0x0667);
>
> - if (phy->connected) {
> + if (phy->type == BCM43xx_PHYTYPE_G) {
I don't think this is correct.
I think (didn't verify) the specs talk about the "gmode" here.
I think you have been misleaded by that. The "gmode" bit is
the "connected" bit in the old softmac driver.
--
Greetings Michael.
next prev parent reply other threads:[~2007-02-13 23:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 22:54 [PATCH] bcm43xx: Fix for 4311 and 02/07/07 specification changes Larry Finger
2007-02-13 23:02 ` Michael Buesch [this message]
2007-02-14 0:42 ` Larry Finger
2007-02-14 22:51 ` Rafael J. Wysocki
2007-02-22 16:07 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702140002.05727.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).