straw poll: new Kconfig symbol for mac80211 debugfs?

straw poll: new Kconfig symbol for mac80211 debugfs?

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

After moving all the sysfs stuff to debugfs I notice that it is quite a
large amount of code. Does anybody think having a new Kconfig symbol for
that like this one

config MAC80211_DEBUGFS
	bool "DebugFS support"
	depends on MAC80211
	---help---
	  Select this to see extensive information about
	  the internal state of mac80211 in debugfs.

	  Say N unless you know you need this.

would make sense?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: straw poll: new Kconfig symbol for mac80211 debugfs?

[Randy Dunlap]

On Sat, 03 Mar 2007 13:12:03 +0100 Johannes Berg wrote:

> After moving all the sysfs stuff to debugfs I notice that it is quite a
> large amount of code. Does anybody think having a new Kconfig symbol for
> that like this one
> 
> config MAC80211_DEBUGFS
> 	bool "DebugFS support"
> 	depends on MAC80211
> 	---help---
> 	  Select this to see extensive information about
> 	  the internal state of mac80211 in debugfs.
> 
> 	  Say N unless you know you need this.
> 
> would make sense?

Yes.  But it should also depend on DEBUG_FS... (maybe it does
that somewhere else?)

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: straw poll: new Kconfig symbol for mac80211 debugfs?

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

On Sat, 2007-03-03 at 07:51 -0800, Randy Dunlap wrote:
> On Sat, 03 Mar 2007 13:12:03 +0100 Johannes Berg wrote:
> 
> > After moving all the sysfs stuff to debugfs I notice that it is quite a
> > large amount of code. Does anybody think having a new Kconfig symbol for
> > that like this one
> > 
> > config MAC80211_DEBUGFS
> > 	bool "DebugFS support"
> > 	depends on MAC80211
> > 	---help---
> > 	  Select this to see extensive information about
> > 	  the internal state of mac80211 in debugfs.
> > 
> > 	  Say N unless you know you need this.
> > 
> > would make sense?
> 
> Yes.  But it should also depend on DEBUG_FS... (maybe it does
> that somewhere else?)

Yeah, I only wrote this right into this email and forgot (and when I
noticed seconds after sending I didn't want to spam everybody again,
sent enough mail already today :) )

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: straw poll: new Kconfig symbol for mac80211 debugfs?

[Michael Buesch]

On Saturday 03 March 2007 13:12, Johannes Berg wrote:
> After moving all the sysfs stuff to debugfs I notice that it is quite a
> large amount of code. Does anybody think having a new Kconfig symbol for
> that like this one
> 
> config MAC80211_DEBUGFS
> 	bool "DebugFS support"
> 	depends on MAC80211
> 	---help---
> 	  Select this to see extensive information about
> 	  the internal state of mac80211 in debugfs.
> 
> 	  Say N unless you know you need this.
> 
> would make sense?

I'd say this doesn't make too much sense. Simply enable it
when CONFIG_D80211_DEBUG is set.

-- 
Greetings Michael.