* [PATCH] bcm43xx: do not rebuild when kernel version changes
@ 2007-03-03 19:03 Sam Ravnborg
2007-03-03 20:21 ` Michael Buesch
0 siblings, 1 reply; 7+ messages in thread
From: Sam Ravnborg @ 2007-03-03 19:03 UTC (permalink / raw)
To: linux-wireless, LKML, Andrew Morton
Replacing use of UTS_RELEASE with utsname()->release
avoids that this module is rebuild each
time the kernel version changes.
Compile tested only.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c b/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c
index c947025..d2df6a0 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c
@@ -32,7 +32,7 @@
#include <linux/netdevice.h>
#include <linux/pci.h>
#include <linux/string.h>
-#include <linux/utsrelease.h>
+#include <linux/utsname.h>
static void bcm43xx_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
@@ -40,7 +40,7 @@ static void bcm43xx_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *
struct bcm43xx_private *bcm = bcm43xx_priv(dev);
strncpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
- strncpy(info->version, UTS_RELEASE, sizeof(info->version));
+ strncpy(info->version, utsname()->release, sizeof(info->version));
strncpy(info->bus_info, pci_name(bcm->pci_dev), ETHTOOL_BUSINFO_LEN);
}
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] bcm43xx: do not rebuild when kernel version changes
2007-03-03 19:03 [PATCH] bcm43xx: do not rebuild when kernel version changes Sam Ravnborg
@ 2007-03-03 20:21 ` Michael Buesch
2007-03-03 21:03 ` Larry Finger
0 siblings, 1 reply; 7+ messages in thread
From: Michael Buesch @ 2007-03-03 20:21 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: linux-wireless, LKML, Andrew Morton, Larry Finger
On Saturday 03 March 2007 20:03, Sam Ravnborg wrote:
> Replacing use of UTS_RELEASE with utsname()->release
> avoids that this module is rebuild each
> time the kernel version changes.
>
> Compile tested only.
I vote to get rid of the whole bcm43xx_ethtool.c file, as it's useless.
It will vanish with the advent of d80211, anyway.
Larry?
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c b/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c
> index c947025..d2df6a0 100644
> --- a/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c
> +++ b/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c
> @@ -32,7 +32,7 @@
> #include <linux/netdevice.h>
> #include <linux/pci.h>
> #include <linux/string.h>
> -#include <linux/utsrelease.h>
> +#include <linux/utsname.h>
>
>
> static void bcm43xx_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
> @@ -40,7 +40,7 @@ static void bcm43xx_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *
> struct bcm43xx_private *bcm = bcm43xx_priv(dev);
>
> strncpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
> - strncpy(info->version, UTS_RELEASE, sizeof(info->version));
> + strncpy(info->version, utsname()->release, sizeof(info->version));
> strncpy(info->bus_info, pci_name(bcm->pci_dev), ETHTOOL_BUSINFO_LEN);
> }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
Greetings Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] bcm43xx: do not rebuild when kernel version changes
2007-03-03 20:21 ` Michael Buesch
@ 2007-03-03 21:03 ` Larry Finger
2007-03-03 21:10 ` Michael Buesch
2007-03-03 21:13 ` Sam Ravnborg
0 siblings, 2 replies; 7+ messages in thread
From: Larry Finger @ 2007-03-03 21:03 UTC (permalink / raw)
To: Michael Buesch; +Cc: Sam Ravnborg, linux-wireless, LKML, Andrew Morton
Michael Buesch wrote:
> On Saturday 03 March 2007 20:03, Sam Ravnborg wrote:
>> Replacing use of UTS_RELEASE with utsname()->release
>> avoids that this module is rebuild each
>> time the kernel version changes.
>>
>> Compile tested only.
>
> I vote to get rid of the whole bcm43xx_ethtool.c file, as it's useless.
> It will vanish with the advent of d80211, anyway.
> Larry?
Is bcm43xx_ethtool.c really useless? If so, I vote to remove it. I have never tried to use ethtool
on bcm43xx. Similarly, it isn't very often that I recompile the kernel when bcm43xx hasn't changed
and would not have noticed the bug that Sam reported.
Larry
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] bcm43xx: do not rebuild when kernel version changes
2007-03-03 21:03 ` Larry Finger
@ 2007-03-03 21:10 ` Michael Buesch
2007-03-03 21:13 ` Sam Ravnborg
1 sibling, 0 replies; 7+ messages in thread
From: Michael Buesch @ 2007-03-03 21:10 UTC (permalink / raw)
To: Larry Finger; +Cc: Sam Ravnborg, linux-wireless, LKML, Andrew Morton
On Saturday 03 March 2007 22:03, Larry Finger wrote:
> Michael Buesch wrote:
> > On Saturday 03 March 2007 20:03, Sam Ravnborg wrote:
> >> Replacing use of UTS_RELEASE with utsname()->release
> >> avoids that this module is rebuild each
> >> time the kernel version changes.
> >>
> >> Compile tested only.
> >
> > I vote to get rid of the whole bcm43xx_ethtool.c file, as it's useless.
> > It will vanish with the advent of d80211, anyway.
> > Larry?
>
> Is bcm43xx_ethtool.c really useless?
Yes it is useless.
1) There isn't really anything ethtool related implemented. Just the useless info stuff.
2) ethtool is rather useless for wireless in general (that's why there isn't
anything implemented ;) )
Please remove the file, kill it from Makefile and remove the ethtool
ops set in main.c (one line).
--
Greetings Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] bcm43xx: do not rebuild when kernel version changes
2007-03-03 21:03 ` Larry Finger
2007-03-03 21:10 ` Michael Buesch
@ 2007-03-03 21:13 ` Sam Ravnborg
1 sibling, 0 replies; 7+ messages in thread
From: Sam Ravnborg @ 2007-03-03 21:13 UTC (permalink / raw)
To: Larry Finger; +Cc: Michael Buesch, linux-wireless, LKML, Andrew Morton
On Sat, Mar 03, 2007 at 03:03:57PM -0600, Larry Finger wrote:
> Michael Buesch wrote:
> > On Saturday 03 March 2007 20:03, Sam Ravnborg wrote:
> >> Replacing use of UTS_RELEASE with utsname()->release
> >> avoids that this module is rebuild each
> >> time the kernel version changes.
> >>
> >> Compile tested only.
> >
> > I vote to get rid of the whole bcm43xx_ethtool.c file, as it's useless.
> > It will vanish with the advent of d80211, anyway.
> > Larry?
>
> Is bcm43xx_ethtool.c really useless? If so, I vote to remove it. I have never tried to use ethtool
> on bcm43xx. Similarly, it isn't very often that I recompile the kernel when bcm43xx hasn't changed
> and would not have noticed the bug that Sam reported.
I saw it only because I tossed around with a allmodconfig build.
I do not care if it is fixed one way or the other - but I like that
only relevant parts are rebuild when kernel version changes.
Sam
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] bcm43xx: do not rebuild when kernel version changes
@ 2007-03-04 5:55 Larry Finger
2007-03-04 12:57 ` Michael Buesch
0 siblings, 1 reply; 7+ messages in thread
From: Larry Finger @ 2007-03-04 5:55 UTC (permalink / raw)
To: John Linville; +Cc: Michael Buesch, Bcm43xx-dev, linux-wireless
From: Sam Ravnborg <sam@ravnborg.org>
In bcm43xx_ethtool, UTS_RELEASE is used. Replacing this with utsname()->release
avoids rebuilding this module each time the kernel version changes.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
John,
As the ethtool removal was NACKed by Jeff, we need to do this one.
Larry
===
diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c b/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c
index c947025..d2df6a0 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c
@@ -32,7 +32,7 @@
#include <linux/netdevice.h>
#include <linux/pci.h>
#include <linux/string.h>
-#include <linux/utsrelease.h>
+#include <linux/utsname.h>
static void bcm43xx_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
@@ -40,7 +40,7 @@ static void bcm43xx_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *
struct bcm43xx_private *bcm = bcm43xx_priv(dev);
strncpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
- strncpy(info->version, UTS_RELEASE, sizeof(info->version));
+ strncpy(info->version, utsname()->release, sizeof(info->version));
strncpy(info->bus_info, pci_name(bcm->pci_dev), ETHTOOL_BUSINFO_LEN);
}
-
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] bcm43xx: do not rebuild when kernel version changes
2007-03-04 5:55 Larry Finger
@ 2007-03-04 12:57 ` Michael Buesch
0 siblings, 0 replies; 7+ messages in thread
From: Michael Buesch @ 2007-03-04 12:57 UTC (permalink / raw)
To: Larry Finger; +Cc: John Linville, Bcm43xx-dev, linux-wireless
On Sunday 04 March 2007 06:55, Larry Finger wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
>
> In bcm43xx_ethtool, UTS_RELEASE is used. Replacing this with utsname()->release
> avoids rebuilding this module each time the kernel version changes.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> John,
>
> As the ethtool removal was NACKed by Jeff, we need to do this one.
What the fuck, why?
> Larry
>
> ===
>
> diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c b/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c
> index c947025..d2df6a0 100644
> --- a/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c
> +++ b/drivers/net/wireless/bcm43xx/bcm43xx_ethtool.c
> @@ -32,7 +32,7 @@
> #include <linux/netdevice.h>
> #include <linux/pci.h>
> #include <linux/string.h>
> -#include <linux/utsrelease.h>
> +#include <linux/utsname.h>
>
>
> static void bcm43xx_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
> @@ -40,7 +40,7 @@ static void bcm43xx_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *
> struct bcm43xx_private *bcm = bcm43xx_priv(dev);
>
> strncpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
> - strncpy(info->version, UTS_RELEASE, sizeof(info->version));
> + strncpy(info->version, utsname()->release, sizeof(info->version));
> strncpy(info->bus_info, pci_name(bcm->pci_dev), ETHTOOL_BUSINFO_LEN);
> }
>
> -
>
>
>
--
Greetings Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-03-04 12:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-03 19:03 [PATCH] bcm43xx: do not rebuild when kernel version changes Sam Ravnborg
2007-03-03 20:21 ` Michael Buesch
2007-03-03 21:03 ` Larry Finger
2007-03-03 21:10 ` Michael Buesch
2007-03-03 21:13 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2007-03-04 5:55 Larry Finger
2007-03-04 12:57 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).