From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <larry.finger@lwfinger.net>
Cc: Sam Ravnborg <sam@ravnborg.org>,
linux-wireless@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] bcm43xx: do not rebuild when kernel version changes
Date: Sat, 3 Mar 2007 22:10:31 +0100 [thread overview]
Message-ID: <200703032210.31546.mb@bu3sch.de> (raw)
In-Reply-To: <45E9E2BD.9070106@lwfinger.net>
On Saturday 03 March 2007 22:03, Larry Finger wrote:
> Michael Buesch wrote:
> > On Saturday 03 March 2007 20:03, Sam Ravnborg wrote:
> >> Replacing use of UTS_RELEASE with utsname()->release
> >> avoids that this module is rebuild each
> >> time the kernel version changes.
> >>
> >> Compile tested only.
> >
> > I vote to get rid of the whole bcm43xx_ethtool.c file, as it's useless.
> > It will vanish with the advent of d80211, anyway.
> > Larry?
>
> Is bcm43xx_ethtool.c really useless?
Yes it is useless.
1) There isn't really anything ethtool related implemented. Just the useless info stuff.
2) ethtool is rather useless for wireless in general (that's why there isn't
anything implemented ;) )
Please remove the file, kill it from Makefile and remove the ethtool
ops set in main.c (one line).
--
Greetings Michael.
next prev parent reply other threads:[~2007-03-03 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-03 19:03 [PATCH] bcm43xx: do not rebuild when kernel version changes Sam Ravnborg
2007-03-03 20:21 ` Michael Buesch
2007-03-03 21:03 ` Larry Finger
2007-03-03 21:10 ` Michael Buesch [this message]
2007-03-03 21:13 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2007-03-04 5:55 Larry Finger
2007-03-04 12:57 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703032210.31546.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@osdl.org \
--cc=larry.finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).