From: Michael Wu <flamingice@sourmilk.net>
To: Helge Deller <deller@gmx.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] p54 various cleanups
Date: Sun, 4 Mar 2007 00:18:55 -0500 [thread overview]
Message-ID: <200703040019.00159.flamingice@sourmilk.net> (raw)
In-Reply-To: <200703021945.20954.deller@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
On Friday 02 March 2007 13:45, Helge Deller wrote:
> -static unsigned int tx_ring_size = 16;
> -static unsigned int rx_ring_size = 16;
> -static int debug = 1;
> +static unsigned int tx_ring_size __read_mostly = 16;
> +static unsigned int rx_ring_size __read_mostly = 16;
> +static int debug __read_mostly = 1;
>
Hm, sure why not..
> -const u8 rtl8225_agc[] = {
> +const const u8 rtl8225_agc[] = {
What does const const do?
> -static const char *rfs[] = {
> +static const char * const rfs[] = {
?
BTW, you should have an updated summary for this patch.
Rest of the patch looks okay to me.
Thanks,
-Michael Wu
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-03-04 5:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 21:19 [PATCH] p54 various cleanups Helge Deller
2007-02-27 23:26 ` Michael Wu
2007-03-02 18:45 ` Helge Deller
2007-03-04 5:18 ` Michael Wu [this message]
2007-03-05 16:06 ` Helge Deller
2007-03-07 18:15 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703040019.00159.flamingice@sourmilk.net \
--to=flamingice@sourmilk.net \
--cc=deller@gmx.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).