From: Michael Buesch <mb@bu3sch.de>
To: Jiri Benc <jbenc@suse.cz>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>
Subject: [PATCH] mac80211: Properly kill tasklets before shutdown
Date: Tue, 6 Mar 2007 19:01:59 +0100 [thread overview]
Message-ID: <200703061902.00001.mb@bu3sch.de> (raw)
We need to do tasklet_kill() on any tasklet on unregister
to make sure the tasklet is not running _and_ scheduled anymore.
(tasklet_disable() only ensures it's not running anymore).
This fixes the tasklet related crash that was reported some time ago.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Index: bu3sch-wireless-dev/net/mac80211/ieee80211.c
===================================================================
--- bu3sch-wireless-dev.orig/net/mac80211/ieee80211.c 2007-03-06 15:55:53.000000000 +0100
+++ bu3sch-wireless-dev/net/mac80211/ieee80211.c 2007-03-06 15:58:10.000000000 +0100
@@ -4761,8 +4761,8 @@
struct ieee80211_sub_if_data *sdata, *tmp;
int i;
- tasklet_disable(&local->tasklet);
- /* TODO: skb_queue should be empty here, no need to do anything? */
+ tasklet_kill(&local->tx_pending_tasklet);
+ tasklet_kill(&local->tasklet);
rtnl_lock();
local->reg_state = IEEE80211_DEV_UNREGISTERED;
--
Greetings Michael.
next reply other threads:[~2007-03-06 18:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 18:01 Michael Buesch [this message]
2007-03-08 1:26 ` [PATCH] mac80211: Properly kill tasklets before shutdown Johannes Berg
2007-03-08 15:39 ` Michael Buesch
2007-03-08 15:43 ` Johannes Berg
2007-03-16 18:22 ` Michael Buesch
2007-03-23 17:17 ` Jiri Benc
2007-03-23 17:22 ` Michael Buesch
2007-03-23 17:32 ` Jiri Benc
2007-03-23 18:36 ` Michael Buesch
2007-03-23 20:16 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703061902.00001.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).