Re: [PATCH] mac80211: Properly kill tasklets before shutdown

[Michael Buesch <mb@bu3sch.de>]

On Thursday 08 March 2007 02:26, Johannes Berg wrote:
> On Tue, 2007-03-06 at 19:01 +0100, Michael Buesch wrote:
> 
> > This fixes the tasklet related crash that was reported some time ago.
> 
> I agree with that :)
>  
> > -	tasklet_disable(&local->tasklet);
> > -	/* TODO: skb_queue should be empty here, no need to do anything? */
> > +	tasklet_kill(&local->tx_pending_tasklet);
> > +	tasklet_kill(&local->tasklet);
> 
> But I'm not sure this is sufficient. I think we can then leak pending
> skbs.

I don't think so. tasklet_kill does actually waiting, not killing.
It waits until the (maybe) scheduled tasklet did run and then waits
for it to finish running.
It doesn't rip off a scheduled tasklet without letting it run.

> In my tests I've often gotten that warning message about the skb 
> queue not being empty (right before the crash). Or is that handled
> elsewhere now?

Uh, didn't get that. The assertion for this is in the same function
some lines down.

-- 
Greetings Michael.