Re: [PATCH] mac80211: Prevent unregistering of unregistered hw

[Michael Buesch <mb@bu3sch.de>]

On Friday 09 March 2007 16:14, Ivo van Doorn wrote:
> At the moment it is possible to call ieee80211_unregister_hw()
> for an unregistered hw structure. This will cause a big panic.
> This patch will add a check to check if IEEE80211_DEV_REGISTERED
> has been set before attempting to unregister hw.

For which reason would a driver call unregister, but not register before?
I smell design problems in the driver ;)

> Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
> 
> ---
> 
> diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
> index 577dbe3..7494280 100644
> --- a/net/mac80211/ieee80211.c
> +++ b/net/mac80211/ieee80211.c
> @@ -4765,6 +4765,12 @@ void ieee80211_unregister_hw(struct ieee80211_hw *hw)
>  	/* TODO: skb_queue should be empty here, no need to do anything? */
>  
>  	rtnl_lock();
> +
> +	if (local->reg_state != IEEE80211_DEV_REGISTERED) {
> +		rtnl_unlock();
> +		return;
> +	}
> +
>  	local->reg_state = IEEE80211_DEV_UNREGISTERED;
>  	if (local->apdev)
>  		ieee80211_if_del_mgmt(local);

-- 
Greetings Michael.