From: Ivo van Doorn <ivdoorn@gmail.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: "John Linville" <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Prevent unregistering of unregistered hw
Date: Fri, 9 Mar 2007 17:30:06 +0100 [thread overview]
Message-ID: <200703091730.06796.IvDoorn@gmail.com> (raw)
In-Reply-To: <200703091646.05292.mb@bu3sch.de>
On Friday 09 March 2007 16:46, Michael Buesch wrote:
> On Friday 09 March 2007 16:14, Ivo van Doorn wrote:
> > At the moment it is possible to call ieee80211_unregister_hw()
> > for an unregistered hw structure. This will cause a big panic.
> > This patch will add a check to check if IEEE80211_DEV_REGISTERED
> > has been set before attempting to unregister hw.
>
> For which reason would a driver call unregister, but not register before?
Well it occurred in rt2x00 during errors during initialization,
instead of using goto's to step by step free all allocated memory and unregistration
the main free_dev() was called. And there isn't a way for the driver to check
if the hw has been registered or not without creating new flags for it.
But since mac80211 already is using such a flag internally, it would sound like
more sense to make the check in there.
> I smell design problems in the driver ;)
True, there are different approaches to take care of this inside the driver,
but I think this check is sane enough as well. ;)
Ivo
next prev parent reply other threads:[~2007-03-09 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 15:14 [PATCH] mac80211: Prevent unregistering of unregistered hw Ivo van Doorn
2007-03-09 15:46 ` Michael Buesch
2007-03-09 16:30 ` Ivo van Doorn [this message]
2007-03-22 10:37 ` Johannes Berg
2007-03-22 10:49 ` Ivo Van Doorn
2007-03-23 17:36 ` Jiri Benc
2007-03-23 20:08 ` [PATCH] mac80211: BUG_ON unregistering unregistered device Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703091730.06796.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).