From: "John W. Linville" <linville@tuxdriver.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] bcm43xx: Add firmware version to ethtool output
Date: Fri, 16 Mar 2007 13:14:27 -0400 [thread overview]
Message-ID: <20070316171427.GC3426@tuxdriver.com> (raw)
In-Reply-To: <200703042002.39581.mb@bu3sch.de>
On Sun, Mar 04, 2007 at 08:02:39PM +0100, Michael Buesch wrote:
> On Sunday 04 March 2007 19:55, Larry Finger wrote:
> > @@ -42,6 +43,8 @@ static void bcm43xx_get_drvinfo(struct n
> > strncpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
> > strncpy(info->version, utsname()->release, sizeof(info->version));
> > strncpy(info->bus_info, pci_name(bcm->pci_dev), ETHTOOL_BUSINFO_LEN);
> > + snprintf(info->fw_version, sizeof(info->fw_version), "0x%x",
> > + bcm43xx_shm_read16(bcm, BCM43xx_SHM_SHARED, BCM43xx_UCODE_REVISION));
>
> This will crash when the device is not up.
Larry, will you be doing a new version of this patch that accounts
for this comment?
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-03-16 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-04 18:55 [PATCH] bcm43xx: Add firmware version to ethtool output Larry Finger
2007-03-04 19:02 ` Michael Buesch
2007-03-16 17:14 ` John W. Linville [this message]
2007-03-16 18:13 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070316171427.GC3426@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).