From: Michael Wu <flamingice@sourmilk.net>
To: Dan Williams <dcbw@redhat.com>
Cc: Hong Liu <hong.liu@intel.com>, Jiri Benc <jbenc@suse.cz>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/5] mac80211: fix key restricted/open display
Date: Sat, 17 Mar 2007 00:57:51 -0400 [thread overview]
Message-ID: <200703170058.01020.flamingice@sourmilk.net> (raw)
In-Reply-To: <1174106316.3026.19.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
On Saturday 17 March 2007 00:38, Dan Williams wrote:
> On Fri, 2007-03-16 at 23:57 -0400, Michael Wu wrote:
> > On Friday 16 March 2007 23:46, Dan Williams wrote:
> > > I think you're misreading the patch? It looks correct to me. The
> > > second check for (erq->flags & IW_ENCODE_RESTRICTED) should ensure that
> > > Shared Key is only selected when the userspace program requested it.
> >
> > This breaks authentication algorithm fallback for sure.
>
> Well, then it's broken in most of the non mac80211 drivers then.
>
Why is that? The reason this breaks mac80211 is because auth_algs is a
bitfield which indicates what authentication algorithms can be used. This
patch makes it so that if a user chooses an authentication algorithm, that is
the only one that will ever be used.
> Well, if mac80211 can cycle (is this like airo's auto_wep?) then I guess
> we don't care about the auth mode. As long as we don't break userspace
> programs that try to set the auth mode, I'm fine with that.
>
mac80211 should just ignore the bits. Airo's auto_wep appears to cycle through
different encryption keys while mac80211 does not.
-Michael Wu
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-03-17 4:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 3:28 [PATCH 3/5] mac80211: fix key restricted/open display Hong Liu
2007-03-16 17:28 ` Michael Wu
2007-03-17 3:46 ` Dan Williams
2007-03-17 3:57 ` Michael Wu
2007-03-17 4:38 ` Dan Williams
2007-03-17 4:57 ` Michael Wu [this message]
2007-03-17 17:23 ` Dan Williams
2007-03-18 16:45 ` Jouni Malinen
2007-03-18 23:35 ` Dan Williams
2007-03-22 3:43 ` Hong Liu
2007-03-23 18:27 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703170058.01020.flamingice@sourmilk.net \
--to=flamingice@sourmilk.net \
--cc=dcbw@redhat.com \
--cc=hong.liu@intel.com \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).