From: Michael Buesch <mb@bu3sch.de>
To: Jiri Benc <jbenc@suse.cz>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] mac80211: Properly kill tasklets before shutdown
Date: Fri, 23 Mar 2007 19:36:42 +0100 [thread overview]
Message-ID: <200703231936.42249.mb@bu3sch.de> (raw)
In-Reply-To: <20070323183220.11ffb2a3@griffin.suse.cz>
On Friday 23 March 2007 18:32, Jiri Benc wrote:
> On Fri, 23 Mar 2007 18:22:50 +0100, Michael Buesch wrote:
> > kill == (make sure it's not scheduled anymore) && disable
>
> Are you sure? I cannot find anything in tasklet_kill which disables the
> tasklet.
It doesn't bounce the count, but it waits for the tasklet to finish
and makes sure it's not scheduled anymore.
Why do you want to inc the count? There is no point in that.
disable does: Wait for it to finish running && inc the count
kill does: make sure it's not scheduled, wait for it to finish.
Why disable it? If there's anything scheduling the tasklet while
we have unregistered we _want_ it to crash, as that's a real bug
in the first place. (And I don't think it's possible to
schedule it after unregister).
--
Greetings Michael.
next prev parent reply other threads:[~2007-03-23 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 18:01 [PATCH] mac80211: Properly kill tasklets before shutdown Michael Buesch
2007-03-08 1:26 ` Johannes Berg
2007-03-08 15:39 ` Michael Buesch
2007-03-08 15:43 ` Johannes Berg
2007-03-16 18:22 ` Michael Buesch
2007-03-23 17:17 ` Jiri Benc
2007-03-23 17:22 ` Michael Buesch
2007-03-23 17:32 ` Jiri Benc
2007-03-23 18:36 ` Michael Buesch [this message]
2007-03-23 20:16 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703231936.42249.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).