* [PATCH] bcm43xx-mac80211: fix radio_set_tx_iq
@ 2007-03-23 19:23 Stefano Brivio
2007-03-23 20:25 ` Michael Buesch
0 siblings, 1 reply; 2+ messages in thread
From: Stefano Brivio @ 2007-03-23 19:23 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, bcm43xx-dev
Fix a duplicated leftshift in bcm43xx_radio_set_tx_iq. data_high values are
already leftshifted. Thanks to Michael Buesch for spotting this.
Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
---
diff --git a/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c b/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
index 10a82b1..a2c52f6 100644
--- a/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
+++ b/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
@@ -3802,7 +3802,7 @@ void bcm43xx_radio_set_tx_iq(struct bcm4
for (i = 0; i < 5; i++) {
for (j = 0; j < 5; j++) {
- if (tmp == (data_high[i] << 4 | data_low[j])) {
+ if (tmp == (data_high[i] | data_low[j])) {
bcm43xx_phy_write(dev, 0x0069, (i - j) << 8 | 0x00C0);
return;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bcm43xx-mac80211: fix radio_set_tx_iq
2007-03-23 19:23 [PATCH] bcm43xx-mac80211: fix radio_set_tx_iq Stefano Brivio
@ 2007-03-23 20:25 ` Michael Buesch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Buesch @ 2007-03-23 20:25 UTC (permalink / raw)
To: Stefano Brivio; +Cc: John Linville, linux-wireless, bcm43xx-dev
On Friday 23 March 2007 20:23, Stefano Brivio wrote:
> Fix a duplicated leftshift in bcm43xx_radio_set_tx_iq. data_high values are
> already leftshifted. Thanks to Michael Buesch for spotting this.
>
> Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
I think you should probably write your APHY stuff against the development
tree, as only that has proper support for multiple 802.11 cores (4309).
> diff --git a/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c b/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
> index 10a82b1..a2c52f6 100644
> --- a/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
> +++ b/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
> @@ -3802,7 +3802,7 @@ void bcm43xx_radio_set_tx_iq(struct bcm4
>
> for (i = 0; i < 5; i++) {
> for (j = 0; j < 5; j++) {
> - if (tmp == (data_high[i] << 4 | data_low[j])) {
> + if (tmp == (data_high[i] | data_low[j])) {
> bcm43xx_phy_write(dev, 0x0069, (i - j) << 8 | 0x00C0);
> return;
> }
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-23 20:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-23 19:23 [PATCH] bcm43xx-mac80211: fix radio_set_tx_iq Stefano Brivio
2007-03-23 20:25 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).