From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jiri Benc <jbenc@suse.cz>, John <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: Prevent unregistering of unregistered hw
Date: Fri, 23 Mar 2007 23:17:48 +0100 [thread overview]
Message-ID: <200703232317.48451.IvDoorn@gmail.com> (raw)
In-Reply-To: <1174680868.4470.8.camel@johannes.berg>
On Friday 23 March 2007 21:14, Johannes Berg wrote:
> On Fri, 2007-03-23 at 20:21 +0100, Ivo van Doorn wrote:
>
> > diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
> > index 577dbe3..e7a613d 100644
> > --- a/net/mac80211/ieee80211.c
> > +++ b/net/mac80211/ieee80211.c
> > @@ -4765,6 +4765,9 @@ void ieee80211_unregister_hw(struct ieee80211_hw *hw)
> > /* TODO: skb_queue should be empty here, no need to do anything? */
> >
> > rtnl_lock();
> > +
> > + BUG_ON(local->reg_state != IEEE80211_DEV_REGISTERED);
> > +
>
> Hm. Maybe that's better since then there's no race like in my patch. Use
> this one instead of mine please. But it does kill the system pretty
> badly if you BUG_ON with rtnl held :)
Well it would increase motivation to fix such a bug in the driver then. ;)
(yes, fixing that bug in rt2x00 is on my todo list :P)
Ivo
prev parent reply other threads:[~2007-03-23 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 19:21 [PATCH v2] mac80211: Prevent unregistering of unregistered hw Ivo van Doorn
2007-03-23 20:14 ` Johannes Berg
2007-03-23 20:33 ` Jiri Benc
2007-03-23 22:17 ` Ivo van Doorn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703232317.48451.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).