From: Michael Buesch <mb@bu3sch.de>
To: Andy Green <andy@warmcat.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Jiri Benc <jbenc@suse.cz>, Daniel Drake <dsd@gentoo.org>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
kune@deine-taler.de
Subject: Re: [PATCH] zd1211rw-mac80211: Fix for monitor mode bug
Date: Mon, 26 Mar 2007 13:28:27 +0200 [thread overview]
Message-ID: <200703261328.28156.mb@bu3sch.de> (raw)
In-Reply-To: <46079CEC.5030207@warmcat.com>
On Monday 26 March 2007 12:14, Andy Green wrote:
> Johannes Berg wrote:
>
> > bcm43xx doesn't tell you when the CRC failed, nor does it tell you when
> > the PLCP CRC failed (if you want to see those frames). Hence, we'd have
> > to recheck the CRC(s).
>
> FWIW I can definitely use the broken frames despite the overhead and
> would welcome being able to get them via a config option.
We currently have two module parameters in bcm43xx-mac80211 for this:
static int modparam_mon_keep_bad;
module_param_named(mon_keep_bad, modparam_mon_keep_bad, int, 0444);
MODULE_PARM_DESC(mon_keep_bad, "Keep bad frames in monitor mode");
static int modparam_mon_keep_badplcp;
module_param_named(mon_keep_badplcp, modparam_mon_keep_bad, int, 0444);
MODULE_PARM_DESC(mon_keep_badplcp, "Keep frames with bad PLCP in monitor mode");
Of course, it might be desired to have that knob in mac80211 and cfg80211, somehow.
--
Greetings Michael.
next prev parent reply other threads:[~2007-03-26 11:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-25 23:18 [PATCH] zd1211rw-mac80211: Fix for monitor mode bug Daniel Drake
2007-03-26 9:54 ` Jiri Benc
2007-03-26 9:59 ` Johannes Berg
2007-03-26 10:14 ` Andy Green
2007-03-26 11:28 ` Michael Buesch [this message]
2007-03-26 11:31 ` Johannes Berg
2007-03-26 20:39 ` Michael Buesch
2007-03-28 9:19 ` Johannes Berg
2007-03-28 9:55 ` Michael Buesch
2007-03-28 10:18 ` PLCP header information (was: Re: [PATCH] zd1211rw-mac80211: Fix for monitor mode bug) Johannes Berg
2007-03-26 10:28 ` [PATCH] zd1211rw-mac80211: Fix for monitor mode bug Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703261328.28156.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=andy@warmcat.com \
--cc=dsd@gentoo.org \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).