linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jouni Malinen" <jkm@devicescape.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>, Jouni Malinen <j@w1.fi>
Subject: Re: WPA/RSN information in cfg80211?
Date: Wed, 28 Mar 2007 12:00:17 -0700	[thread overview]
Message-ID: <20070328190017.GI6036@devicescape.com> (raw)
In-Reply-To: <1175034846.5151.20.camel@johannes.berg>

On Wed, Mar 28, 2007 at 12:34:06AM +0200, Johannes Berg wrote:

> Looking through wpa_supplicant and then through the kernel I notice that
> we currently in the kernel special-case some things in SIOCSIWAUTH, for
> example IW_AUTH_WPA_VERSION is ignored since we rely on the IE that wpa
> supplicant gave us.

Use of WPA/RSN IE vs. individual parameters depends on the driver. For
example, NDIS drivers generate the IEs internally and need to be
configured with the key management (WPA-PSK, WPA-Enterprise, WPA2-PSK,
WPA2-Enterprise, ..) and cipher suites separately. They would not use
WPA/RSN IE at all. Some drivers use the IE so that kernel code does not
need to have all the code for generating it. They may (or may not,
depending on needs) ignore the individual values.

> Apart from how wrong I think this is (we shouldn't be allowing a setting
> we can't do, we need to return some error code and wpa_supplicant should
> sort it out) I also found only one occurrence in prism54 where the
> parameters are actually not ignored. Is that driver fully replaced by
> p54?

Those two options are there for a reason and which one will be used will
depend on the driver. At the moment, wpa_supplicant does not really like
the error code, but if I remember correctly, it will, in practice), try
to continue associating anyway and the only problem is a bit confusing
output in debug log. Returning -EOPNOTSUPP for parameters that are not
used should be fine.

> Is there any point in supporting these at all?

Yes.

> I'm inclined to just require userspace to put both the IE and the
> individual settings into the relevant nl80211 messages, but then we
> might just as well piece the IE together from those settings, no?

As long as the information is available for the driver at the time of
association request, it does not really matter how that information got
there..

-- 
Jouni Malinen                                            PGP id EFC895FA

  parent reply	other threads:[~2007-03-28 19:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-27 22:34 WPA/RSN information in cfg80211? Johannes Berg
2007-03-28  9:33 ` Mark Powell
2007-03-28  9:47   ` Johannes Berg
2007-03-28 10:04     ` Mark Powell
2007-03-28 10:24       ` Johannes Berg
2007-03-28 14:47 ` Dan Williams
2007-03-28 19:00 ` Jouni Malinen [this message]
2007-03-29 11:12   ` Johannes Berg
2007-03-29 15:44     ` Jouni Malinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070328190017.GI6036@devicescape.com \
    --to=jkm@devicescape.com \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).