From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Michael Wu <flamingice@sourmilk.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wext: allow wext users without rtnl
Date: Wed, 18 Apr 2007 14:04:51 -0700 [thread overview]
Message-ID: <20070418140451.075370fc@freekitty> (raw)
In-Reply-To: <1176825010.3902.28.camel@johannes.berg>
On Tue, 17 Apr 2007 17:50:10 +0200
Johannes Berg <johannes@sipsolutions.net> wrote:
> This patch modifies wext adding a flag that allows drivers to specify that
> they do not wish their wext calls made under rtnl. The default is to still
> acquire the rtnl.
>
> Warning: a device reference is held for the new no_locking API,
> therefore it is not safe to call unregister_netdev on the passed device!
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>
>
NACK Conditional locking is bad design.
Either lock or not, make up your mind and fix the devices.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-04-18 21:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 15:50 [PATCH] wext: allow wext users without rtnl Johannes Berg
2007-04-18 21:04 ` Stephen Hemminger [this message]
2007-04-18 21:09 ` David Miller
2007-04-19 10:12 ` Johannes Berg
2007-04-20 19:48 ` Johannes Berg
2007-04-20 20:32 ` David Miller
2007-04-20 20:53 ` Johannes Berg
2007-04-20 21:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070418140451.075370fc@freekitty \
--to=shemminger@linux-foundation.org \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox