From: Stefano Brivio <stefano.brivio@polimi.it>
To: Michael Wu <flamingice@sourmilk.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Andrea Merello <andreamrl@tiscali.it>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtl818x-mac80211: fix coding style
Date: Fri, 20 Apr 2007 09:02:18 +0200 [thread overview]
Message-ID: <20070420090218.5a51d363@localhost> (raw)
In-Reply-To: <200704191923.31674.flamingice@sourmilk.net>
On Thu, 19 Apr 2007 19:23:26 -0400
Michael Wu <flamingice@sourmilk.net> wrote:
> On Thursday 19 April 2007 18:42, Stefano Brivio wrote:
> > Fix coding style.
> >
> Looks mostly good except for..
>
> > - // ehh?
> > + // XXX: ehh?
> Use FIXME if you want to put in a prefix.
"XXX:" means we don't know if it's a FIXME, a TODO or just correct code.
It's quite used. Unless this is a clear FIXME, I'd keep it.
> > -} __attribute__ ((packed));
> > +} __attribute__((packed));
> I prefer the space here.
Please see CodingStyle.
--
Ciao
Stefano
next prev parent reply other threads:[~2007-04-20 7:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 22:42 [PATCH] rtl818x-mac80211: fix coding style Stefano Brivio
2007-04-19 23:23 ` Michael Wu
2007-04-20 7:02 ` Stefano Brivio [this message]
2007-04-20 13:07 ` Michael Wu
2007-04-20 13:46 ` [PATCH #2] " Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070420090218.5a51d363@localhost \
--to=stefano.brivio@polimi.it \
--cc=andreamrl@tiscali.it \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).