From: Ivo van Doorn <ivdoorn@gmail.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: Jiri Benc <jbenc@suse.cz>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/4] mac80211: document requirement for atomicity of callbacks
Date: Sun, 29 Apr 2007 11:20:33 +0200 [thread overview]
Message-ID: <200704291120.33910.IvDoorn@gmail.com> (raw)
In-Reply-To: <200704291115.43657.mb@bu3sch.de>
On Sunday 29 April 2007 11:15, Michael Buesch wrote:
> On Sunday 29 April 2007 02:33:45 Jiri Benc wrote:
> > @@ -631,7 +632,8 @@ struct ieee80211_ops {
> > * we need to combine the multicast lists and flags for multiple
> > * virtual interfaces), they cannot assign set_multicast_list.
> > * The parameters here replace dev->flags and dev->mc_count,
> > - * dev->mc_list is replaced by calling ieee80211_get_mc_list_item. */
> > + * dev->mc_list is replaced by calling ieee80211_get_mc_list_item.
> > + * Must be atomic. */
> > void (*set_multicast_list)(struct ieee80211_hw *hw,
> > unsigned short flags, int mc_count);
>
> Why is that required to be atomic, actually?
Because set_multicast_list callback inside the netdevice structure
is also called atomically. So if this should be moved out of atomic context
either the kernel shouldn't call it from atomic context or mac80211 needs to
reschedule the call to the driver.
Ivo
next prev parent reply other threads:[~2007-04-29 9:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-29 0:32 [PATCH 1/4] mac80211: remove unused code Jiri Benc
2007-04-29 0:33 ` [PATCH 2/4] mac80211: remove test_mode Jiri Benc
2007-04-29 0:33 ` [PATCH 3/4] mac80211: document requirement for atomicity of callbacks Jiri Benc
2007-04-29 9:15 ` Michael Buesch
2007-04-29 9:20 ` Ivo van Doorn [this message]
2007-04-29 10:49 ` Jiri Benc
2007-04-29 12:53 ` Michael Buesch
2007-04-29 0:34 ` [PATCH] mac80211: add copyrights Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704291120.33910.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).