Re: 2.6.21-mm1

Re: 2.6.21-mm1

[Andrew Morton]

On Sat, 05 May 2007 17:48:28 +0200 Maciej Rutecki <maciej.rutecki@gmail.com> wrote:

> Andrew Morton pisze:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm1/
> > 
> > 
> 
> CC [M]  lib/zlib_deflate/deflate_syms.o
>   LD [M]  lib/zlib_deflate/zlib_deflate.o
>   Building modules, stage 2.
>   MODPOST 791 modules
> ERROR: "ssb_pcihost_register" [drivers/net/b44.ko] undefined!
> ERROR: "ssb_pcihost_unregister" [drivers/net/b44.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
> make[1]: Leaving directory `/usr/src/linux-mm'
> make: *** [debian/stamp-build-kernel] Error 2
> 
> Config:
> http://www.unixy.pl/maciek/download/kernel/2.6.21-mm1/config-2.6.21-mm1.gz
> 

OK, thanks.  I assume that's a Kconfig mistake in the wireless tree.

But it looks like a real minefield:


+static inline void b44_pci_exit(void)
+{
+#ifdef CONFIG_B44_PCI
+	ssb_pcihost_unregister(&b44_pci_driver);
+#endif
+}

and

+#ifdef CONFIG_BCM43XX_MAC80211_PCI
+	ssb_pcihost_unregister(&bcm43xx_pci_driver);
+#endif

and

+#ifdef CONFIG_SSB_PCIHOST
+/* PCI-host wrapper driver */
+extern int ssb_pcihost_register(struct pci_driver *driver);
+static inline void ssb_pcihost_unregister(struct pci_driver *driver)
+{
+	pci_unregister_driver(driver);
+}
+#endif /* CONFIG_SSB_PCIHOST */


That looks waaaaaay more complicated than it needs to be.

I'm thinking that the first two ifdefs should be removed and that third one
needs a #else clause which implements stubs and that b44 Kconfig needs to
be taught about CONFIG_SSB_PCIHOST in some fashion.

Or something like that.

Re: 2.6.21-mm1

[Michael Buesch]

On Saturday 05 May 2007 20:48:11 Andrew Morton wrote:
> On Sat, 05 May 2007 17:48:28 +0200 Maciej Rutecki <maciej.rutecki@gmail.com> wrote:
> 
> > Andrew Morton pisze:
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm1/
> > > 
> > > 
> > 
> > CC [M]  lib/zlib_deflate/deflate_syms.o
> >   LD [M]  lib/zlib_deflate/zlib_deflate.o
> >   Building modules, stage 2.
> >   MODPOST 791 modules
> > ERROR: "ssb_pcihost_register" [drivers/net/b44.ko] undefined!
> > ERROR: "ssb_pcihost_unregister" [drivers/net/b44.ko] undefined!
> > make[2]: *** [__modpost] Error 1
> > make[1]: *** [modules] Error 2
> > make[1]: Leaving directory `/usr/src/linux-mm'
> > make: *** [debian/stamp-build-kernel] Error 2

config B44_PCI
	bool "Broadcom 4400 PCI device support"
	depends on B44 && NET_PCI

We simply need a SELECT SSB_PCIHOST here. Not sure why it's not there.
I thought it used to be there.

-- 
Greetings Michael.

Re: 2.6.21-mm1

[John W. Linville]

On Sat, May 05, 2007 at 11:48:49PM +0200, Michael Buesch wrote:
> On Saturday 05 May 2007 20:48:11 Andrew Morton wrote:
> > On Sat, 05 May 2007 17:48:28 +0200 Maciej Rutecki <maciej.rutecki@gmail.com> wrote:
> > 
> > > Andrew Morton pisze:
> > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm1/
> > > > 
> > > > 
> > > 
> > > CC [M]  lib/zlib_deflate/deflate_syms.o
> > >   LD [M]  lib/zlib_deflate/zlib_deflate.o
> > >   Building modules, stage 2.
> > >   MODPOST 791 modules
> > > ERROR: "ssb_pcihost_register" [drivers/net/b44.ko] undefined!
> > > ERROR: "ssb_pcihost_unregister" [drivers/net/b44.ko] undefined!
> > > make[2]: *** [__modpost] Error 1
> > > make[1]: *** [modules] Error 2
> > > make[1]: Leaving directory `/usr/src/linux-mm'
> > > make: *** [debian/stamp-build-kernel] Error 2
> 
> config B44_PCI
> 	bool "Broadcom 4400 PCI device support"
> 	depends on B44 && NET_PCI
> 
> We simply need a SELECT SSB_PCIHOST here. Not sure why it's not there.
> I thought it used to be there.

That may have only been applied to the mm-master branch, which now
no longer exists.  I'll patch it now.

John
-- 
John W. Linville
linville@tuxdriver.com