* Re: 2.6.21-mm1 [not found] ` <463CA74C.8080008@gmail.com> @ 2007-05-05 18:48 ` Andrew Morton 2007-05-05 21:48 ` 2.6.21-mm1 Michael Buesch 0 siblings, 1 reply; 3+ messages in thread From: Andrew Morton @ 2007-05-05 18:48 UTC (permalink / raw) To: Maciej Rutecki; +Cc: linux-kernel, linux-wireless, John W. Linville On Sat, 05 May 2007 17:48:28 +0200 Maciej Rutecki <maciej.rutecki@gmail.com> wrote: > Andrew Morton pisze: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm1/ > > > > > > CC [M] lib/zlib_deflate/deflate_syms.o > LD [M] lib/zlib_deflate/zlib_deflate.o > Building modules, stage 2. > MODPOST 791 modules > ERROR: "ssb_pcihost_register" [drivers/net/b44.ko] undefined! > ERROR: "ssb_pcihost_unregister" [drivers/net/b44.ko] undefined! > make[2]: *** [__modpost] Error 1 > make[1]: *** [modules] Error 2 > make[1]: Leaving directory `/usr/src/linux-mm' > make: *** [debian/stamp-build-kernel] Error 2 > > Config: > http://www.unixy.pl/maciek/download/kernel/2.6.21-mm1/config-2.6.21-mm1.gz > OK, thanks. I assume that's a Kconfig mistake in the wireless tree. But it looks like a real minefield: +static inline void b44_pci_exit(void) +{ +#ifdef CONFIG_B44_PCI + ssb_pcihost_unregister(&b44_pci_driver); +#endif +} and +#ifdef CONFIG_BCM43XX_MAC80211_PCI + ssb_pcihost_unregister(&bcm43xx_pci_driver); +#endif and +#ifdef CONFIG_SSB_PCIHOST +/* PCI-host wrapper driver */ +extern int ssb_pcihost_register(struct pci_driver *driver); +static inline void ssb_pcihost_unregister(struct pci_driver *driver) +{ + pci_unregister_driver(driver); +} +#endif /* CONFIG_SSB_PCIHOST */ That looks waaaaaay more complicated than it needs to be. I'm thinking that the first two ifdefs should be removed and that third one needs a #else clause which implements stubs and that b44 Kconfig needs to be taught about CONFIG_SSB_PCIHOST in some fashion. Or something like that. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.6.21-mm1 2007-05-05 18:48 ` 2.6.21-mm1 Andrew Morton @ 2007-05-05 21:48 ` Michael Buesch 2007-05-05 22:25 ` 2.6.21-mm1 John W. Linville 0 siblings, 1 reply; 3+ messages in thread From: Michael Buesch @ 2007-05-05 21:48 UTC (permalink / raw) To: Andrew Morton Cc: Maciej Rutecki, linux-kernel, linux-wireless, John W. Linville On Saturday 05 May 2007 20:48:11 Andrew Morton wrote: > On Sat, 05 May 2007 17:48:28 +0200 Maciej Rutecki <maciej.rutecki@gmail.com> wrote: > > > Andrew Morton pisze: > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm1/ > > > > > > > > > > CC [M] lib/zlib_deflate/deflate_syms.o > > LD [M] lib/zlib_deflate/zlib_deflate.o > > Building modules, stage 2. > > MODPOST 791 modules > > ERROR: "ssb_pcihost_register" [drivers/net/b44.ko] undefined! > > ERROR: "ssb_pcihost_unregister" [drivers/net/b44.ko] undefined! > > make[2]: *** [__modpost] Error 1 > > make[1]: *** [modules] Error 2 > > make[1]: Leaving directory `/usr/src/linux-mm' > > make: *** [debian/stamp-build-kernel] Error 2 config B44_PCI bool "Broadcom 4400 PCI device support" depends on B44 && NET_PCI We simply need a SELECT SSB_PCIHOST here. Not sure why it's not there. I thought it used to be there. -- Greetings Michael. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.6.21-mm1 2007-05-05 21:48 ` 2.6.21-mm1 Michael Buesch @ 2007-05-05 22:25 ` John W. Linville 0 siblings, 0 replies; 3+ messages in thread From: John W. Linville @ 2007-05-05 22:25 UTC (permalink / raw) To: Michael Buesch Cc: Andrew Morton, Maciej Rutecki, linux-kernel, linux-wireless On Sat, May 05, 2007 at 11:48:49PM +0200, Michael Buesch wrote: > On Saturday 05 May 2007 20:48:11 Andrew Morton wrote: > > On Sat, 05 May 2007 17:48:28 +0200 Maciej Rutecki <maciej.rutecki@gmail.com> wrote: > > > > > Andrew Morton pisze: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm1/ > > > > > > > > > > > > > > CC [M] lib/zlib_deflate/deflate_syms.o > > > LD [M] lib/zlib_deflate/zlib_deflate.o > > > Building modules, stage 2. > > > MODPOST 791 modules > > > ERROR: "ssb_pcihost_register" [drivers/net/b44.ko] undefined! > > > ERROR: "ssb_pcihost_unregister" [drivers/net/b44.ko] undefined! > > > make[2]: *** [__modpost] Error 1 > > > make[1]: *** [modules] Error 2 > > > make[1]: Leaving directory `/usr/src/linux-mm' > > > make: *** [debian/stamp-build-kernel] Error 2 > > config B44_PCI > bool "Broadcom 4400 PCI device support" > depends on B44 && NET_PCI > > We simply need a SELECT SSB_PCIHOST here. Not sure why it's not there. > I thought it used to be there. That may have only been applied to the mm-master branch, which now no longer exists. I'll patch it now. John -- John W. Linville linville@tuxdriver.com ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-05 22:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070505014955.8f3990b5.akpm@linux-foundation.org>
[not found] ` <463CA74C.8080008@gmail.com>
2007-05-05 18:48 ` 2.6.21-mm1 Andrew Morton
2007-05-05 21:48 ` 2.6.21-mm1 Michael Buesch
2007-05-05 22:25 ` 2.6.21-mm1 John W. Linville
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).