Please pull 'master' branch of libertas (for 2.6.22)

Please pull 'master' branch of libertas (for 2.6.22)

[Dan Williams]

John,

This is latest libertas git and should be pushed to 2.6.22.  It takes
care of a few of Christoph's objections, including ioctl removal,
version.h removal, and debug define cleanups.

git://git.infradead.org/libertas-2.6.git

Thanks,
Dan

Re: Please pull 'master' branch of libertas (for 2.6.22)

[John W. Linville]

On Wed, May 09, 2007 at 05:16:14PM -0400, Dan Williams wrote:

> This is latest libertas git and should be pushed to 2.6.22.  It takes
> care of a few of Christoph's objections, including ioctl removal,
> version.h removal, and debug define cleanups.
> 
> git://git.infradead.org/libertas-2.6.git

Dan,

There is a problem...the libertas-2.6 tree doesn't have a "clean"
history.  It appears to have the entire development history of the
libertas project.  We need something more concise and "sanitized"
for pushing upstream.

We do not really want the patches for new development, at least not
for 2.6.22.  Could you help identify which patches in the history
correspond to review fixes?

I can generate a single diff, but it is huge ("34 files changed, 3069
insertions(+), 5643 deletions(-)") and it isn't clear to me that it
is only cleanups.  Perhaps you could split this up into a few separate
patches?  Especially those patches specific to review comments?

I'm sorry...I know this is a PITA.  I appreciate your effort and
cooperation.

John
-- 
John W. Linville
linville@tuxdriver.com

Re: Please pull 'master' branch of libertas (for 2.6.22)

[Dan Williams]

On Wed, 2007-05-09 at 21:35 -0400, John W. Linville wrote:
> On Wed, May 09, 2007 at 05:16:14PM -0400, Dan Williams wrote:
> 
> > This is latest libertas git and should be pushed to 2.6.22.  It takes
> > care of a few of Christoph's objections, including ioctl removal,
> > version.h removal, and debug define cleanups.
> > 
> > git://git.infradead.org/libertas-2.6.git
> 
> Dan,
> 
> There is a problem...the libertas-2.6 tree doesn't have a "clean"
> history.  It appears to have the entire development history of the
> libertas project.  We need something more concise and "sanitized"
> for pushing upstream.

Yeah; that sucks.  I've pulled wireless-2.6 and I'm adding
cleanup/review patches now.  What I may not be able to do, depending on
time, is fix the warnings and sparse stuff Randy brought up.

Dan

> We do not really want the patches for new development, at least not
> for 2.6.22.  Could you help identify which patches in the history
> correspond to review fixes?
> 
> I can generate a single diff, but it is huge ("34 files changed, 3069
> insertions(+), 5643 deletions(-)") and it isn't clear to me that it
> is only cleanups.  Perhaps you could split this up into a few separate
> patches?  Especially those patches specific to review comments?
> 
> I'm sorry...I know this is a PITA.  I appreciate your effort and
> cooperation.
> 
> John

Re: Please pull 'master' branch of libertas (for 2.6.22)

[Dan Williams]

On Thu, 2007-05-10 at 10:35 -0400, Dan Williams wrote:
> On Wed, 2007-05-09 at 21:35 -0400, John W. Linville wrote:
> > On Wed, May 09, 2007 at 05:16:14PM -0400, Dan Williams wrote:
> > 
> > > This is latest libertas git and should be pushed to 2.6.22.  It takes
> > > care of a few of Christoph's objections, including ioctl removal,
> > > version.h removal, and debug define cleanups.
> > > 
> > > git://git.infradead.org/libertas-2.6.git
> > 
> > Dan,
> > 
> > There is a problem...the libertas-2.6 tree doesn't have a "clean"
> > history.  It appears to have the entire development history of the
> > libertas project.  We need something more concise and "sanitized"
> > for pushing upstream.
> 
> Yeah; that sucks.  I've pulled wireless-2.6 and I'm adding
> cleanup/review patches now.  What I may not be able to do, depending on
> time, is fix the warnings and sparse stuff Randy brought up.

I've had the time to do the sparse fixes and am finishing up the compile
warnings.

Dan

> Dan
> 
> > We do not really want the patches for new development, at least not
> > for 2.6.22.  Could you help identify which patches in the history
> > correspond to review fixes?
> > 
> > I can generate a single diff, but it is huge ("34 files changed, 3069
> > insertions(+), 5643 deletions(-)") and it isn't clear to me that it
> > is only cleanups.  Perhaps you could split this up into a few separate
> > patches?  Especially those patches specific to review comments?
> > 
> > I'm sorry...I know this is a PITA.  I appreciate your effort and
> > cooperation.
> > 
> > John
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html