From: "John W. Linville" <linville@tuxdriver.com>
To: Michael Wu <flamingice@sourmilk.net>
Cc: linux-wireless@vger.kernel.org, Ivo van Doorn <ivdoorn@gmail.com>
Subject: Re: [PATCH 1/2] Add 93cx6 eeprom library
Date: Sat, 12 May 2007 15:17:49 -0400 [thread overview]
Message-ID: <20070512191749.GA6018@tuxdriver.com> (raw)
In-Reply-To: <200705111559.41153.flamingice@sourmilk.net>
On Fri, May 11, 2007 at 03:59:40PM -0400, Michael Wu wrote:
> +static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom)
> +{
> + eeprom->reg_data_clock = 1;
> + eeprom->register_write(eeprom);
> + udelay(1);
> +}
> +
> +static inline void eeprom_93cx6_pulse_low(struct eeprom_93cx6 *eeprom)
> +{
> + eeprom->reg_data_clock = 0;
> + eeprom->register_write(eeprom);
> + udelay(1);
> +}
I'm with Jeff, these udelay's should go. If they belong anywhere, it
would be in the write routines provided by the caller. For example, the
routines provided by rtl8187 already have a delay in them. Other
hardware might actually have a hardware timer to implement delays (hey,
it's possible). Either way, this delay is superfluous.
> +}
> +EXPORT_SYMBOL_GPL(eeprom_93cx6_multiread);
> +
It's pedantic, but I hate empty lines at the end of files...
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-05-12 19:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 19:59 [PATCH 1/2] Add 93cx6 eeprom library Michael Wu
2007-05-11 20:07 ` Ivo van Doorn
2007-05-12 19:17 ` John W. Linville [this message]
2007-05-13 1:29 ` Michael Wu
2007-05-13 8:13 ` Ivo van Doorn
2007-05-13 8:22 ` Johannes Berg
2007-05-13 18:50 ` Jeff Garzik
2007-05-14 17:45 ` John W. Linville
-- strict thread matches above, loose matches on Subject: below --
2007-05-07 7:46 Michael Wu
2007-05-07 7:53 ` Ivo van Doorn
2007-05-07 14:27 ` Ben Dooks
2007-05-07 15:34 ` John W. Linville
2007-05-07 15:40 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070512191749.GA6018@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=flamingice@sourmilk.net \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).