* [PATCH] eeprom_93cx6: Add comment for 1us delay after pulse
@ 2007-05-14 21:06 Ivo van Doorn
2007-05-15 2:49 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Ivo van Doorn @ 2007-05-14 21:06 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless
This will add a comment for the 1us delay which is taken
after the pulse has been switched. The 1us delay is based
on the specifications so that should be made clear.
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
diff --git a/drivers/misc/eeprom_93cx6.c b/drivers/misc/eeprom_93cx6.c
index a948ddc..8c8b43f 100644
--- a/drivers/misc/eeprom_93cx6.c
+++ b/drivers/misc/eeprom_93cx6.c
@@ -39,6 +39,12 @@ static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom)
{
eeprom->reg_data_clock = 1;
eeprom->register_write(eeprom);
+
+ /*
+ * Add a short delay for the pulse to work.
+ * According to the specifications the minimal time
+ * should be 450ns so a 1us delay is sufficient.
+ */
udelay(1);
}
@@ -46,6 +52,12 @@ static inline void eeprom_93cx6_pulse_low(struct eeprom_93cx6 *eeprom)
{
eeprom->reg_data_clock = 0;
eeprom->register_write(eeprom);
+
+ /*
+ * Add a short delay for the pulse to work.
+ * According to the specifications the minimal time
+ * should be 450ns so a 1us delay is sufficient.
+ */
udelay(1);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] eeprom_93cx6: Add comment for 1us delay after pulse
2007-05-14 21:06 [PATCH] eeprom_93cx6: Add comment for 1us delay after pulse Ivo van Doorn
@ 2007-05-15 2:49 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-05-15 2:49 UTC (permalink / raw)
To: Ivo van Doorn; +Cc: John Linville, linux-wireless
Ivo van Doorn wrote:
> This will add a comment for the 1us delay which is taken
> after the pulse has been switched. The 1us delay is based
> on the specifications so that should be made clear.
>
> Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
>
> ---
>
> diff --git a/drivers/misc/eeprom_93cx6.c b/drivers/misc/eeprom_93cx6.c
> index a948ddc..8c8b43f 100644
> --- a/drivers/misc/eeprom_93cx6.c
> +++ b/drivers/misc/eeprom_93cx6.c
> @@ -39,6 +39,12 @@ static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom)
> {
> eeprom->reg_data_clock = 1;
> eeprom->register_write(eeprom);
> +
> + /*
> + * Add a short delay for the pulse to work.
> + * According to the specifications the minimal time
> + * should be 450ns so a 1us delay is sufficient.
> + */
> udelay(1);
> }
>
> @@ -46,6 +52,12 @@ static inline void eeprom_93cx6_pulse_low(struct eeprom_93cx6 *eeprom)
> {
> eeprom->reg_data_clock = 0;
> eeprom->register_write(eeprom);
> +
> + /*
> + * Add a short delay for the pulse to work.
> + * According to the specifications the minimal time
> + * should be 450ns so a 1us delay is sufficient.
> + */
> udelay(1);
why not ndelay(450)?
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-15 2:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-14 21:06 [PATCH] eeprom_93cx6: Add comment for 1us delay after pulse Ivo van Doorn
2007-05-15 2:49 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).