From: Michael Buesch <mb@bu3sch.de>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: "Michael Wu" <flamingice@sourmilk.net>,
"John Linville" <linville@tuxdriver.com>,
"Jeff Garzik" <jeff@garzik.org>,
linux-wireless@vger.kernel.org,
"David Miller" <davem@davemloft.net>,
"Andrea Merello" <andrea.merello@gmail.com>
Subject: Re: [PATCH 2/2] Add rtl8187 wireless driver
Date: Thu, 17 May 2007 22:41:18 +0200 [thread overview]
Message-ID: <200705172241.18515.mb@bu3sch.de> (raw)
In-Reply-To: <43e72e890705171243g7e3d65e4ne43b5956e13f44db@mail.gmail.com>
On Thursday 17 May 2007 21:43:37 Luis R. Rodriguez wrote:
> On 5/11/07, Michael Wu <flamingice@sourmilk.net> wrote:
>
> > diff --git a/drivers/net/wireless/rtl8187_dev.c b/drivers/net/wireless/rtl8187_dev.c
> > new file mode 100644
> > index 0000000..10bec9d
> > --- /dev/null
> > +++ b/drivers/net/wireless/rtl8187_dev.c
>
> ...
>
> > +static int rtl8187_tx(struct ieee80211_hw *dev, struct sk_buff *skb,
> > + struct ieee80211_tx_control *control)
> > +{
>
> ...
>
> > + info->control = kmemdup(control, sizeof(*control), GFP_ATOMIC);
>
> kmemdup can fail, add:
>
> if (!info->control)
> return -ENOMEM;
The TX callback expects one of the following return types:
080 /* Driver transmit return codes */
081 #define NETDEV_TX_OK 0 /* driver took care of packet */
082 #define NETDEV_TX_BUSY 1 /* driver tx path was busy*/
083 #define NETDEV_TX_LOCKED -1 /* driver tx lock was already taken */
So most likely you want NETDEV_TX_BUSY here.
--
Greetings Michael.
next prev parent reply other threads:[~2007-05-17 20:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070511195642.8042.20407.stgit@panda.sourmilk.net>
2007-05-11 20:02 ` [PATCH 2/2] Add rtl8187 wireless driver Michael Wu
2007-05-12 19:18 ` John W. Linville
2007-05-13 1:56 ` Michael Wu
2007-05-13 10:07 ` Andrea Merello
2007-05-14 20:34 ` John W. Linville
2007-05-14 20:29 ` John W. Linville
2007-05-17 5:48 ` Michael Wu
2007-05-17 15:31 ` John W. Linville
2007-05-17 19:43 ` Luis R. Rodriguez
2007-05-17 20:41 ` Michael Buesch [this message]
2007-05-18 6:50 ` Michael Wu
[not found] <20070507073636.4232.93444.stgit@panda.sourmilk.net>
2007-05-07 7:46 ` Michael Wu
2007-05-07 8:15 ` Christoph Hellwig
2007-05-07 8:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705172241.18515.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=andrea.merello@gmail.com \
--cc=davem@davemloft.net \
--cc=flamingice@sourmilk.net \
--cc=jeff@garzik.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).