linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: yi.zhu@intel.com
Cc: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	Michael Wu <flamingice@sourmilk.net>
Subject: Re: [PATCH 3/3] mac80211: debugfs support for TSM and DLS
Date: Fri, 25 May 2007 09:20:08 -0700	[thread overview]
Message-ID: <20070525092008.287b5ecd.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20070525115244.GA23364@mail.intel.com>

On Fri, 25 May 2007 19:52:44 +0800 Zhu Yi wrote:

>  net/mac80211/debugfs_netdev.c |  332 +++++++++++++++++++++++++++++++++++++++++
>  net/mac80211/ieee80211_i.h    |   33 ++++
>  2 files changed, 365 insertions(+), 0 deletions(-)
> 
> diff --git a/net/mac80211/debugfs_netdev.c b/net/mac80211/debugfs_netdev.c
> index 9e39646..e0f77f9 100644
> --- a/net/mac80211/debugfs_netdev.c
> +++ b/net/mac80211/debugfs_netdev.c

> +#define DEBUGFS_QOS_DEL(name)						\
> +	debugfs_remove(sdata->debugfs.sta.qos.name);			\
> +	sdata->debugfs.sta.qos.name = NULL;

Enclose multi-line macros inside braces, or even better, inside

	do {
		/* multi-lines */
	} while (0);


> +#define DEBUGFS_TSINFO_DEL(name)					\
> +	debugfs_remove(sdata->debugfs.sta.tsinfo.name);			\
> +	sdata->debugfs.sta.tsinfo.name = NULL;

ditto.

> +#define DEBUGFS_TSPEC_DEL(name)						\
> +	debugfs_remove(sdata->debugfs.sta.tspec.name);			\
> +	sdata->debugfs.sta.tspec.name = NULL;

ditto.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2007-05-25 16:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-25 11:52 [PATCH 3/3] mac80211: debugfs support for TSM and DLS Zhu Yi
2007-05-25 16:20 ` Randy Dunlap [this message]
2007-05-25 16:26   ` Michael Buesch
2007-05-28  1:43     ` Zhu Yi
  -- strict thread matches above, loose matches on Subject: below --
2007-06-06  8:22 Zhu Yi
2007-06-07 20:39 ` Jiri Benc
2007-06-08  1:17   ` Zhu Yi
2007-06-08  9:59     ` Jiri Benc
2007-05-14  5:15 Zhu Yi
2007-05-24  7:12 ` Michael Wu
2007-05-24  7:51   ` Zhu Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070525092008.287b5ecd.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=flamingice@sourmilk.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).