From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Michael Buesch <mb@bu3sch.de>
Cc: "Gary Zambrano" <zambrano@broadcom.com>,
"Maximilian Engelhardt" <maxi@daemonizer.de>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
"linux-wireless" <linux-wireless@vger.kernel.org>,
"Arnaldo Carvalho de Melo" <acme@ghostprotocols.net>,
"Jeff Garzik" <jgarzik@pobox.com>,
netdev@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: b44: regression in 2.6.22 (resend)
Date: Tue, 29 May 2007 14:01:55 -0700 [thread overview]
Message-ID: <20070529140155.07693380@freepuppy> (raw)
In-Reply-To: <200705292245.22940.mb@bu3sch.de>
I am busy bisecting the real cause. Unfortunately, oprofile doesn't work
on the laptop, and build time sucks...
This how I think the IRQ should work:
--- a/drivers/net/b44.c 2007-05-29 09:47:53.000000000 -0700
+++ b/drivers/net/b44.c 2007-05-29 09:49:50.000000000 -0700
@@ -908,9 +908,11 @@ static irqreturn_t b44_interrupt(int irq
u32 istat, imask;
int handled = 0;
- spin_lock(&bp->lock);
-
istat = br32(bp, B44_ISTAT);
+ if (istat == 0 || istat == ~0)
+ return IRQ_NONE;
+
+ spin_lock(&bp->lock);
imask = br32(bp, B44_IMASK);
/* The interrupt mask register controls which interrupt bits
next prev parent reply other threads:[~2007-05-29 21:17 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070525172431.60affaca@freepuppy>
[not found] ` <200705261901.18110.mb@bu3sch.de>
2007-05-27 19:25 ` b44: regression in 2.6.22 (resend) Maximilian Engelhardt
2007-05-27 19:45 ` Michael Buesch
2007-05-27 20:36 ` Maximilian Engelhardt
2007-05-27 20:46 ` Michael Buesch
2007-05-27 21:46 ` Maximilian Engelhardt
2007-05-27 21:13 ` Michael Buesch
2007-05-27 21:16 ` Michael Buesch
2007-05-27 21:50 ` Maximilian Engelhardt
2007-05-27 22:15 ` Maximilian Engelhardt
2007-05-28 0:24 ` Michael Buesch
2007-05-28 0:40 ` Maximilian Engelhardt
2007-05-28 10:16 ` Michael Buesch
2007-05-28 14:09 ` Maximilian Engelhardt
2007-05-28 15:14 ` Michael Buesch
2007-05-28 15:32 ` Thomas Gleixner
2007-05-28 15:43 ` Michael Buesch
2007-05-28 17:44 ` Maximilian Engelhardt
2007-05-28 19:23 ` Thomas Gleixner
2007-05-28 20:55 ` Maximilian Engelhardt
2007-05-28 21:45 ` Thomas Gleixner
2007-05-29 18:28 ` Maximilian Engelhardt
2007-05-29 13:58 ` Gary Zambrano
2007-05-29 17:23 ` Maximilian Engelhardt
2007-06-03 16:26 ` Maximilian Engelhardt
2007-06-04 6:39 ` Thomas Gleixner
2007-06-04 16:09 ` Stephen Hemminger
2007-06-04 16:35 ` Thomas Gleixner
2007-06-04 16:59 ` iperf: performance regression (was b44 driver problem?) Stephen Hemminger
2007-06-04 17:32 ` Thomas Gleixner
2007-06-04 17:51 ` Stephen Hemminger
2007-06-04 19:00 ` Thomas Gleixner
2007-06-04 19:26 ` Thomas Gleixner
2007-06-04 19:32 ` Ingo Molnar
2007-06-04 19:47 ` Maximilian Engelhardt
2007-06-04 20:02 ` Stephen Hemminger
2007-06-04 20:52 ` Maximilian Engelhardt
2007-05-28 10:49 ` b44: regression in 2.6.22 (resend) Michael Buesch
2007-05-28 14:12 ` Maximilian Engelhardt
2007-05-28 14:55 ` Michael Buesch
2007-05-29 14:14 ` Gary Zambrano
2007-05-29 20:45 ` Michael Buesch
2007-05-29 21:01 ` Stephen Hemminger [this message]
2007-05-29 21:05 ` Gary Zambrano
2007-05-29 22:39 ` Jeff Garzik
2007-05-29 21:36 ` Gary Zambrano
2007-05-30 10:45 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070529140155.07693380@freepuppy \
--to=shemminger@linux-foundation.org \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maxi@daemonizer.de \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).