From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Wu <flamingice@sourmilk.net>, Jiri Benc <jbenc@suse.cz>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Update stop_queues kdoc
Date: Fri, 1 Jun 2007 11:53:46 +0200 [thread overview]
Message-ID: <200706011153.46914.mb@bu3sch.de> (raw)
In-Reply-To: <1180691291.18266.3.camel@johannes.berg>
On Friday 01 June 2007 11:48:11 Johannes Berg wrote:
> On Fri, 2007-06-01 at 11:29 +0200, Michael Buesch wrote:
> > This updates stop_queue(s) kdoc as currently there's
> > a undocumented dependency.
> >
> > Stopping the queue from anywhere else than the ops->tx()
> > callback will result in a hard to debug deadlock and
> > system freeze (on UP).
>
> Ugh. Any way to actually detect a wrong spot to call it at runtime?
Probably by verifying if netif_tx_lock is locked somehow.
But I'm not sure.
--
Greetings Michael.
next prev parent reply other threads:[~2007-06-01 9:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 9:29 [PATCH] mac80211: Update stop_queues kdoc Michael Buesch
2007-06-01 9:48 ` Johannes Berg
2007-06-01 9:53 ` Michael Buesch [this message]
2007-06-01 11:55 ` Olivier Cornu
2007-06-01 20:42 ` Michael Buesch
2007-06-01 21:00 ` Olivier Cornu
2007-06-01 21:42 ` Michael Buesch
2007-06-01 21:53 ` Olivier Cornu
2007-06-02 13:17 ` Olivier Cornu
2007-06-02 13:37 ` Michael Buesch
2007-06-02 18:41 ` Olivier Cornu
2007-06-01 16:58 ` James Ketrenos
2007-06-01 19:04 ` Michael Wu
2007-06-01 17:32 ` James Ketrenos
2007-06-01 20:36 ` Michael Wu
2007-06-01 20:52 ` Michael Buesch
2007-06-01 20:41 ` Michael Buesch
2007-06-01 20:52 ` Olivier Cornu
2007-06-01 20:54 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706011153.46914.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).