* [PATCH V2] bcm43xx-mac80211: Make wireless statistics yield reasonable values
@ 2007-06-01 21:16 Larry Finger
2007-06-01 21:43 ` Michael Buesch
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2007-06-01 21:16 UTC (permalink / raw)
To: John Linville, Michael Buesch; +Cc: Bcm43xx-dev, linux-wireless
The changes contained herein are needed to get reasonable numbers for wireless
statistics in bcm43xx-mac80211.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
bcm43xx_main.c | 4 ++--
bcm43xx_xmit.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Index: wireless-mb/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_xmit.c
===================================================================
--- wireless-mb.orig/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_xmit.c
+++ wireless-mb/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_xmit.c
@@ -517,12 +517,12 @@ void bcm43xx_rx(struct bcm43xx_wldev *de
}
}
- status.signal = bcm43xx_rssi_postprocess(dev, jssi,
+ status.ssi = bcm43xx_rssi_postprocess(dev, jssi,
(phystat0 & BCM43xx_RX_PHYST0_OFDM),
(phystat0 & BCM43xx_RX_PHYST0_GAINCTL),
(phystat3 & BCM43xx_RX_PHYST3_TRSTATE));
status.noise = dev->stats.link_noise;
- status.ssi = jssi;
+ status.signal = jssi; /* this looks wrong, but is what mac80211 wants */
if (phystat0 & BCM43xx_RX_PHYST0_OFDM)
status.rate = bcm43xx_plcp_get_bitrate_ofdm(plcp);
else
Index: wireless-mb/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c
===================================================================
--- wireless-mb.orig/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c
+++ wireless-mb/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_main.c
@@ -3799,8 +3799,8 @@ static int bcm43xx_wireless_init(struct
IEEE80211_HW_MONITOR_DURING_OPER |
IEEE80211_HW_DEVICE_HIDES_WEP |
IEEE80211_HW_WEP_INCLUDE_IV;
- hw->max_signal = -110;
- hw->max_rssi = BCM43xx_RX_MAX_SSI;
+ hw->max_signal = 100;
+ hw->max_rssi = -110;
hw->max_noise = -110;
hw->queues = 1;
SET_IEEE80211_DEV(hw, dev->dev);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH V2] bcm43xx-mac80211: Make wireless statistics yield reasonable values
2007-06-01 21:16 [PATCH V2] bcm43xx-mac80211: Make wireless statistics yield reasonable values Larry Finger
@ 2007-06-01 21:43 ` Michael Buesch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Buesch @ 2007-06-01 21:43 UTC (permalink / raw)
To: Larry Finger; +Cc: John Linville, Bcm43xx-dev, linux-wireless
On Friday 01 June 2007 23:16:35 Larry Finger wrote:
> The changes contained herein are needed to get reasonable numbers for wireless
> statistics in bcm43xx-mac80211.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
If nobody else complains, go for a merge, John. :)
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-01 21:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-01 21:16 [PATCH V2] bcm43xx-mac80211: Make wireless statistics yield reasonable values Larry Finger
2007-06-01 21:43 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).