From: Zhu Yi <yi.zhu@intel.com>
To: Jiri Benc <jbenc@suse.cz>
Cc: Michael Wu <flamingice@sourmilk.net>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 1/3] mac80211: add IEEE802.11e/WMM structures
Date: Sat, 9 Jun 2007 00:38:43 +0800 [thread overview]
Message-ID: <20070608163843.GA13276@mail.intel.com> (raw)
In-Reply-To: <20070608121628.6c6a810d@griffin.suse.cz>
On Fri, Jun 08, 2007 at 12:16:28PM +0200, Jiri Benc wrote:
> No. Michael is right and I'm really blind I haven't seen that myself.
> That's totally broken. You cannot do _any_ bit operation on __le16.
>
> Let's assume that a value of short1 is 0x34 0x12 (two bytes as stored
> in a memory). Now let's look at the result of (short1 & 0xff).
>
> On a LE platform that's (0x1234 & 0xff), i.e. 0x34.
>
> On a BE platform that's (0x3412 & 0xff), i.e. 0x12.
>
> How that could be correct?
You and Michael are right. The mask (i.e 0x00ff) need a cpu_to_le16()
in this case. I will replace the short with 2 bytes to fix this issue.
Thanks,
-yi
next prev parent reply other threads:[~2007-06-08 16:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 8:22 [PATCH 1/3] mac80211: add IEEE802.11e/WMM structures Zhu Yi
2007-06-07 20:30 ` Jiri Benc
2007-06-08 1:34 ` Zhu Yi
2007-06-08 7:23 ` Johannes Berg
2007-06-08 10:07 ` Jiri Benc
2007-06-08 4:32 ` jketreno
2007-06-07 22:49 ` Jiri Benc
2007-06-07 22:59 ` Jouni Malinen
2007-06-08 2:14 ` Michael Wu
2007-06-08 3:40 ` Zhu Yi
2007-06-08 10:16 ` Jiri Benc
2007-06-08 16:38 ` Zhu Yi [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-05-25 11:52 Zhu Yi
2007-05-14 5:15 Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070608163843.GA13276@mail.intel.com \
--to=yi.zhu@intel.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).