From: "John W. Linville" <linville@tuxdriver.com>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Jiri Benc <jbenc@suse.cz>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH V3] mac80211: Set low initial rate in rc80211_simple
Date: Mon, 11 Jun 2007 13:31:12 -0400 [thread overview]
Message-ID: <20070611173112.GC10397@tuxdriver.com> (raw)
In-Reply-To: <200706072038.36708.flamingice@sourmilk.net>
On Thu, Jun 07, 2007 at 08:38:27PM -0700, Michael Wu wrote:
> On Thursday 07 June 2007 20:03, Larry Finger wrote:
> > for (i = 0; i < mode->num_rates; i++) {
> > if ((sta->supp_rates & BIT(i)) &&
> > (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED))
> > sta->txrate = i;
> > + break;
> > }
> Uh, what's the point of having a loop if you're gonna do that? ;)
How about "I think you forgot some curly braces"? Until Johannes
posted his patch (which you could have done just as easily) I had no
idea what you were talking about here...
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-06-11 17:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 3:03 [PATCH V3] mac80211: Set low initial rate in rc80211_simple Larry Finger
2007-06-08 3:38 ` Michael Wu
2007-06-08 3:49 ` Larry Finger
2007-06-08 5:05 ` Michael Wu
2007-06-08 9:21 ` Jiri Benc
2007-06-08 14:58 ` Jouni Malinen
2007-06-08 18:12 ` Luis R. Rodriguez
2007-06-08 18:34 ` Jouni Malinen
2007-06-08 20:10 ` Luis R. Rodriguez
2007-06-08 21:45 ` Jouni Malinen
2007-06-08 16:35 ` Michael Wu
2007-06-11 17:31 ` John W. Linville [this message]
2007-06-11 18:11 ` Michael Wu
2007-06-11 18:43 ` John W. Linville
2007-06-11 19:09 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070611173112.GC10397@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).