From: David Lamparter <lists@diac24.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: David Lamparter <lists@diac24.net>,
Johannes Berg <johannes@sipsolutions.net>,
John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: use nl80211_* enums
Date: Wed, 13 Jun 2007 14:33:35 +0200 [thread overview]
Message-ID: <20070613123333.GA3440@charon.n2.diac24.net> (raw)
In-Reply-To: <200706122355.36078.flamingice@sourmilk.net>
> > +#include <linux/nl80211.h>
>
> It seems to me that cfg80211 shouldn't depend on nl80211, so the
> nl80211_iftype enum should be moved to cfg80211.h and become cfg80211_iftype.
That's not possible because nl80211_{iftype,phymode} are userspace API.
If they were defined in cfg80211.h, nl80211.h would need to at least mirror
them. And since nl80211.h can't include cfg80211.h (since the former is a
"public" header supposed to go to /usr/include with some linux-headers-*
package), this way around is the simplest and cleanest solution.
Anyway, I don't really think including a header to be a "dependency". You
can disable the nl80211 implementation and still use the API enum just
fine. (Note that nl80211.h contains enums, more enums and ONLY enums :)
-David
next prev parent reply other threads:[~2007-06-13 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-11 22:12 [PATCH] cfg80211: use nl80211_* enums David Lamparter
2007-06-12 9:08 ` Johannes Berg
2007-06-13 6:55 ` Michael Wu
2007-06-13 12:33 ` David Lamparter [this message]
2007-06-13 15:53 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070613123333.GA3440@charon.n2.diac24.net \
--to=lists@diac24.net \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox