linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
	dcbw@redhat.com, hs4233@mail.mn-solutions.de,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: libertas (private) ioctls vs. nl80211
Date: Thu, 14 Jun 2007 10:38:36 -0700	[thread overview]
Message-ID: <20070614103836.23b07a72.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070614170901.GA13384@infradead.org>

> On Thu, 14 Jun 2007 18:09:01 +0100 Christoph Hellwig <hch@infradead.org> wrote:
> Independent of any nl80211 status the private libertas ioctls have to
> go.  Not only don't we want private ioctls for mesh networking but rather
> have it as driver-independent interface, but the actual libertas interface
> is the worst possible choice.  It uses the absolutely broken iwpriv interface
> instead of plain ioctls, and has a cmpletely confusing forest of sub ioctls.
> 
> I strongly recommend ripping out all the ioctls for 2.6.22 and waiting for
> a proper interface to appear.

If we're going to change the interface in the future (and it sounds like
we should) then yes, we should strenuously avoid releasing the current interface
in 2.6.22.

>  The olpc people can patch the ioctls back
> in for their use, but we should not put in interface like this into the
> upstream kernel.  All NIC vendors get pushed back badly when they try
> to put in less crappy ioctls, there is no reason to make a exception for
> libtertas just because it's used by a project that some of the involved
> maintainers like a lot.

I suspect that the probability of your proposal succeeding would be increased
if you could prepare a patch...

  reply	other threads:[~2007-06-14 17:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13 17:58 libertas (private) ioctls vs. nl80211 Johannes Berg
2007-06-14 17:09 ` Christoph Hellwig
2007-06-14 17:38   ` Andrew Morton [this message]
2007-06-14 18:13     ` Christoph Hellwig
2007-06-14 18:23       ` Linus Torvalds
2007-06-14 18:48         ` Jeff Garzik
2007-06-14 22:22           ` Dan Williams
2007-06-14 22:31             ` Christoph Hellwig
2007-06-14 22:55               ` Dan Williams
2007-06-14 19:09         ` John W. Linville
2007-06-14 19:56           ` Andrew Morton
2007-06-14 20:08             ` John W. Linville
2007-06-17  4:46               ` Matt Mackall
2007-07-06 15:40           ` Javier Cardona
2007-07-06 16:08             ` Dan Williams
2007-07-10 14:56               ` John W. Linville
2007-07-10 15:18                 ` John W. Linville
2007-06-18 17:38       ` Dan Williams
2007-06-18 18:44         ` Christoph Hellwig
2007-06-18 18:57           ` Sam Ravnborg
2007-06-14 20:03   ` Holger Schurig
2007-06-14 22:48     ` Dan Williams
2007-06-15 18:42 ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070614103836.23b07a72.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dcbw@redhat.com \
    --cc=hch@infradead.org \
    --cc=hs4233@mail.mn-solutions.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).