From: Sam Ravnborg <sam@ravnborg.org>
To: Christoph Hellwig <hch@infradead.org>,
Dan Williams <dcbw@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
hs4233@mail.mn-solutions.de, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: libertas (private) ioctls vs. nl80211
Date: Mon, 18 Jun 2007 20:57:04 +0200 [thread overview]
Message-ID: <20070618185704.GA25340@uranus.ravnborg.org> (raw)
In-Reply-To: <20070618184436.GC17479@infradead.org>
On Mon, Jun 18, 2007 at 07:44:36PM +0100, Christoph Hellwig wrote:
> On Mon, Jun 18, 2007 at 01:38:47PM -0400, Dan Williams wrote:
> > On Thu, 2007-06-14 at 19:13 +0100, Christoph Hellwig wrote:
> > > > I suspect that the probability of your proposal succeeding would be increased
> > > > if you could prepare a patch...
> >
> > Applied to upstream-fixes branch of libertas-2.6 which is destined for
> > 2.6.22; I hope you don't mind that I just added the Signed-off-by for
> > you.
>
> Adding a signed off line for a patch that purely removes codes seems
> rather pointless to me, but feel free to add it if you care.
THe Signed-off-by: document the path a given patch have taken on its way
to the final acceptance and does not have any significance whatsoever
about the content of the patch. Anyone on the Signed-of-by route
may change the patch (and I often do so) without further notice.
So judging if a Signed-off-by: should be added or not based on
patch content is wrong. It is a patch anyway.
That said the legal(in a loose definition of legal) rationale may
be of much less significance when trivially removing some code.
But we use the same mechanish even to cover spelling corrections.
Sam
next prev parent reply other threads:[~2007-06-18 18:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 17:58 libertas (private) ioctls vs. nl80211 Johannes Berg
2007-06-14 17:09 ` Christoph Hellwig
2007-06-14 17:38 ` Andrew Morton
2007-06-14 18:13 ` Christoph Hellwig
2007-06-14 18:23 ` Linus Torvalds
2007-06-14 18:48 ` Jeff Garzik
2007-06-14 22:22 ` Dan Williams
2007-06-14 22:31 ` Christoph Hellwig
2007-06-14 22:55 ` Dan Williams
2007-06-14 19:09 ` John W. Linville
2007-06-14 19:56 ` Andrew Morton
2007-06-14 20:08 ` John W. Linville
2007-06-17 4:46 ` Matt Mackall
2007-07-06 15:40 ` Javier Cardona
2007-07-06 16:08 ` Dan Williams
2007-07-10 14:56 ` John W. Linville
2007-07-10 15:18 ` John W. Linville
2007-06-18 17:38 ` Dan Williams
2007-06-18 18:44 ` Christoph Hellwig
2007-06-18 18:57 ` Sam Ravnborg [this message]
2007-06-14 20:03 ` Holger Schurig
2007-06-14 22:48 ` Dan Williams
2007-06-15 18:42 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070618185704.GA25340@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=dcbw@redhat.com \
--cc=hch@infradead.org \
--cc=hs4233@mail.mn-solutions.de \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).