From: Michael Wu <flamingice@sourmilk.net>
To: Hong Liu <hong.liu@intel.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Jiri Benc <jbenc@suse.cz>,
linux-wireless@vger.kernel.org
Subject: Re: [patch]mac80211: add support for iwlist channel
Date: Wed, 20 Jun 2007 00:08:43 -0700 [thread overview]
Message-ID: <200706200008.47770.flamingice@sourmilk.net> (raw)
In-Reply-To: <1182308588.19178.17.camel@napa-sdv1.sh.intel.com>
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
On Tuesday 19 June 2007 20:03, Hong Liu wrote:
> + struct ieee80211_hw_mode *mode = NULL;
> + int c = 0;
> +
Shouldn't add an extra empty line here.
> + if (chan->flag & IEEE80211_CHAN_W_SCAN) {
> + range->freq[c].i = chan->chan;
> + range->freq[c].m = chan->freq * 100000;
> + range->freq[c].e = 1;
> + }
> + ++j; ++c;
c shouldn't be incremented if the channel is being skipped.
Also, two minor comments on the style since this patch needs to be revised
anyway - using ++x instead of x++ looks a bit odd, and using 'int j'
when 'int i' is available is also a little strange.
Patch looks good otherwise.
-Michael Wu
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-06-20 7:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 8:47 [patch]mac80211: add support for iwlist channel Hong Liu
2007-06-19 5:12 ` Michael Wu
2007-06-20 3:03 ` Hong Liu
2007-06-20 3:24 ` Larry Finger
2007-06-20 7:08 ` Michael Wu [this message]
2007-06-21 1:43 ` Hong Liu
2007-06-19 8:50 ` Jiri Benc
2007-06-20 2:10 ` Hong Liu
2007-06-20 9:55 ` Jiri Benc
2007-06-20 17:43 ` James Ketrenos
2007-06-20 16:25 ` Jiri Benc
2007-06-20 18:19 ` James Ketrenos
2007-06-20 17:05 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706200008.47770.flamingice@sourmilk.net \
--to=flamingice@sourmilk.net \
--cc=hong.liu@intel.com \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox