Linux wireless drivers development
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	Jiri Benc <jbenc@suse.cz>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: kill antenna select ioctls
Date: Fri, 22 Jun 2007 11:32:29 +0200	[thread overview]
Message-ID: <200706221132.30211.mb@bu3sch.de> (raw)
In-Reply-To: <1182499821.21939.62.camel@johannes.berg>

On Friday 22 June 2007 10:10:20 Johannes Berg wrote:
> Not used anywhere.

It's used in bcm43xx.
Though, I'm not sure anybody in userspace actually calls this strange ioctl.


> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> 
> ---
>  net/mac80211/hostapd_ioctl.h   |    2 --
>  net/mac80211/ieee80211_ioctl.c |   20 --------------------
>  2 files changed, 22 deletions(-)
> 
> --- wireless-dev.orig/net/mac80211/hostapd_ioctl.h	2007-06-22 10:08:24.558632620 +0200
> +++ wireless-dev/net/mac80211/hostapd_ioctl.h	2007-06-22 10:08:56.158632620 +0200
> @@ -31,8 +31,6 @@ enum {
>  	PRISM2_PARAM_HOST_ENCRYPT = 17,
>  	PRISM2_PARAM_HOST_DECRYPT = 18,
>  	PRISM2_PARAM_IEEE_802_1X = 23,
> -	PRISM2_PARAM_ANTSEL_TX = 24,
> -	PRISM2_PARAM_ANTSEL_RX = 25,
>  
>  	/* Instant802 additions */
>  	PRISM2_PARAM_CTS_PROTECT_ERP_FRAMES = 1001,
> --- wireless-dev.orig/net/mac80211/ieee80211_ioctl.c	2007-06-22 10:08:59.318632620 +0200
> +++ wireless-dev/net/mac80211/ieee80211_ioctl.c	2007-06-22 10:09:10.418632620 +0200
> @@ -2167,18 +2167,6 @@ static int ieee80211_ioctl_prism2_param(
>  			sdata->ieee802_1x = value;
>  		break;
>  
> -	case PRISM2_PARAM_ANTSEL_TX:
> -		local->hw.conf.antenna_sel_tx = value;
> -		if (ieee80211_hw_config(local))
> -			ret = -EINVAL;
> -		break;
> -
> -	case PRISM2_PARAM_ANTSEL_RX:
> -		local->hw.conf.antenna_sel_rx = value;
> -		if (ieee80211_hw_config(local))
> -			ret = -EINVAL;
> -		break;
> -
>  	case PRISM2_PARAM_CTS_PROTECT_ERP_FRAMES:
>  		local->cts_protect_erp_frames = value;
>  		break;
> @@ -2377,14 +2365,6 @@ static int ieee80211_ioctl_get_prism2_pa
>  		*param = sdata->ieee802_1x;
>  		break;
>  
> -	case PRISM2_PARAM_ANTSEL_TX:
> -		*param = local->hw.conf.antenna_sel_tx;
> -		break;
> -
> -	case PRISM2_PARAM_ANTSEL_RX:
> -		*param = local->hw.conf.antenna_sel_rx;
> -		break;
> -
>  	case PRISM2_PARAM_CTS_PROTECT_ERP_FRAMES:
>  		*param = local->cts_protect_erp_frames;
>  		break;
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 



-- 
Greetings Michael.

  reply	other threads:[~2007-06-22  9:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-22  8:10 [PATCH] mac80211: kill antenna select ioctls Johannes Berg
2007-06-22  9:32 ` Michael Buesch [this message]
2007-06-22  9:28   ` Ivo van Doorn
2007-06-22  9:45     ` Michael Buesch
2007-06-22 10:01   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706221132.30211.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=jbenc@suse.cz \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox