From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jiri Benc <jbenc@suse.cz>, John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Export short-preamble bit to drivers
Date: Wed, 27 Jun 2007 15:33:56 +0200 [thread overview]
Message-ID: <200706271533.57189.mb@bu3sch.de> (raw)
In-Reply-To: <1182934500.4769.8.camel@johannes.berg>
On Wednesday 27 June 2007 10:55:00 Johannes Berg wrote:
> On Mon, 2007-06-25 at 16:28 +0200, Michael Buesch wrote:
>
> > case PRISM2_PARAM_PREAMBLE:
> > - local->short_preamble = value;
> > + if (value)
> > + local_to_hw(local)->conf.flags |= IEEE80211_CONF_SHORT_PREAMBLE;
> > + else
> > + local_to_hw(local)->conf.flags &= ~IEEE80211_CONF_SHORT_PREAMBLE;
> > + if (ieee80211_hw_config(local))
> > + ret = -EINVAL;
>
> any reason not to return the actual error code from hw_config here? Not
> that it'll be any different from -EINVAL I expect...
>
> johannes
>
Another thing, while we are at it.
How is locking for the conf structure actually done? How is it
made impossible to read the value of "flags" in another thread,
while we update it in a non-atomic way, here?
--
Greetings Michael.
next prev parent reply other threads:[~2007-06-27 13:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 14:28 [PATCH] mac80211: Export short-preamble bit to drivers Michael Buesch
2007-06-27 8:55 ` Johannes Berg
2007-06-27 13:08 ` Michael Buesch
2007-06-27 14:30 ` Johannes Berg
2007-06-27 14:37 ` Michael Buesch
2007-06-27 13:33 ` Michael Buesch [this message]
2007-06-27 13:58 ` Johannes Berg
2007-06-28 1:40 ` Michael Wu
2007-06-28 8:35 ` Michael Buesch
2007-06-28 9:57 ` Johannes Berg
2007-06-29 6:01 ` Michael Wu
2007-06-29 6:07 ` Johannes Berg
2007-06-29 8:13 ` Michael Buesch
2007-06-29 22:39 ` Daniel Drake
2007-06-30 12:47 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706271533.57189.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).