From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Buesch <mb@bu3sch.de>,
linux-wireless@vger.kernel.org, Jiri Benc <jbenc@suse.cz>,
Michael Wu <flamingice@sourmilk.net>
Subject: Re: mac80211/bcm43xx deadlock
Date: Wed, 18 Jul 2007 14:13:47 -0400 [thread overview]
Message-ID: <20070718181347.GD6625@tuxdriver.com> (raw)
In-Reply-To: <1182954090.4769.28.camel@johannes.berg>
On Wed, Jun 27, 2007 at 04:21:30PM +0200, Johannes Berg wrote:
> On Wed, 2007-06-27 at 16:06 +0200, Johannes Berg wrote:
>
> > I'm not convinced this is the same thing, the deadlock here is simply
> > that something running on the workqueue is trying to rtnl_lock() while
> > flushing the workqueue is done under rtnl.
>
> Looking again, Michael agrees that this is not the same deadlock he's
> talking about, so back to the drawing board.
>
> I shall be trying to add lockdep support for this sort of thing, but
> until then how can we fix this? What exactly does the rtnl protect in
> ieee80211_sta_config_auth?
I didn't see an answer here. Before we remove it, I'd prefer to know
what we thought we were protecting in the first place. :-)
John
P.S. Don't get me wrong -- less "big kernel lock" usage is probably
better...
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-07-18 18:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 8:59 mac80211/bcm43xx deadlock Johannes Berg
2007-06-26 10:14 ` Johannes Berg
2007-06-29 6:14 ` Michael Wu
2007-06-26 14:17 ` Michael Buesch
2007-06-27 9:38 ` Johannes Berg
2007-06-27 12:48 ` Michael Buesch
2007-06-27 14:06 ` Johannes Berg
2007-06-27 14:21 ` Johannes Berg
2007-06-27 18:02 ` Johannes Berg
2007-07-18 18:13 ` John W. Linville [this message]
2007-07-18 20:28 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070718181347.GD6625@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).