From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ra.tuxdriver.com ([70.61.120.52]:4644 "EHLO ra.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937340AbXGSTeD (ORCPT ); Thu, 19 Jul 2007 15:34:03 -0400 Date: Thu, 19 Jul 2007 15:15:13 -0400 From: "John W. Linville" To: Daniel Drake Cc: jbenc@suse.cz, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, rt2400-devel@lists.sourceforge.net, mb@bu3sch.de, flamingice@sourmilk.net Subject: Re: [PATCH v2 1/2] mac80211: improved short preamble handling Message-ID: <20070719191513.GD6603@tuxdriver.com> References: <20070715140739.C13187B409F@zog.reactivated.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070715140739.C13187B409F@zog.reactivated.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Jul 15, 2007 at 03:07:39PM +0100, Daniel Drake wrote: > Similarly to CTS protection, whether short preambles are used for 802.11b > transmissions should be a per-subif setting, not device global. > > For STAs, this patch makes short preamble handling automatic based on the ERP > IE. For APs, hostapd still uses the prism ioctls, but the write ioctl has been > restricted to AP-only subifs. > > ieee80211_txrx_data.short_preamble (an unused field) was removed. > > Unfortunately, some API changes were required for the following functions: > - ieee80211_generic_frame_duration > - ieee80211_rts_duration > - ieee80211_ctstoself_duration > - ieee80211_rts_get > - ieee80211_ctstoself_get > Affected drivers (bcm43xx, rt2x00 and rtl8187) were updated accordingly. > > Signed-off-by: Daniel Drake Jiri, Michael -- this applies to upstream w/ just some offsets if you ignore the driver bits that aren't upstream. I'll be happy to handle the patch monkeying if you are happy w/ this patch. John -- John W. Linville linville@tuxdriver.com