* [PATCH] remove duplicated ioctl entries in compat_ioctl.c
@ 2007-07-09 10:54 Masakazu Mokuno
2007-07-09 11:10 ` Holger Schurig
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Masakazu Mokuno @ 2007-07-09 10:54 UTC (permalink / raw)
To: linux-wireless; +Cc: Geert Uytterhoeven, geoffrey.levand
This patch removes some duplicated wireless ioctl entries in the array
'struct ioctl_trans ioctl_start[]' of fs/compat_ioctl.c
These entries are registered twice like:
COMPATIBLE_IOCTL(SIOCGIWPRIV)
and
HANDLE_IOCTL(SIOCGIWPRIV, do_wireless_ioctl)
Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
---
fs/compat_ioctl.c | 3 ---
1 file changed, 3 deletions(-)
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -3156,12 +3156,9 @@ COMPATIBLE_IOCTL(SIOCSIWSENS)
COMPATIBLE_IOCTL(SIOCGIWSENS)
COMPATIBLE_IOCTL(SIOCSIWRANGE)
COMPATIBLE_IOCTL(SIOCSIWPRIV)
-COMPATIBLE_IOCTL(SIOCGIWPRIV)
COMPATIBLE_IOCTL(SIOCSIWSTATS)
-COMPATIBLE_IOCTL(SIOCGIWSTATS)
COMPATIBLE_IOCTL(SIOCSIWAP)
COMPATIBLE_IOCTL(SIOCGIWAP)
-COMPATIBLE_IOCTL(SIOCSIWSCAN)
COMPATIBLE_IOCTL(SIOCSIWRATE)
COMPATIBLE_IOCTL(SIOCGIWRATE)
COMPATIBLE_IOCTL(SIOCSIWRTS)
--
Masakazu MOKUNO
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] remove duplicated ioctl entries in compat_ioctl.c
2007-07-09 10:54 [PATCH] remove duplicated ioctl entries in compat_ioctl.c Masakazu Mokuno
@ 2007-07-09 11:10 ` Holger Schurig
2007-07-09 11:13 ` Holger Schurig
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Holger Schurig @ 2007-07-09 11:10 UTC (permalink / raw)
To: linux-wireless
> This patch removes some duplicated wireless ioctl entries in
> the array 'struct ioctl_trans ioctl_start[]' of
> fs/compat_ioctl.c
> -COMPATIBLE_IOCTL(SIOCSIWSCAN)
> COMPATIBLE_IOCTL(SIOCSIWRATE)
> COMPATIBLE_IOCTL(SIOCGIWRATE)
Maybe you remove the double COMPATIBLE_IOCTL(SIOCGIWRATE) as
well?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] remove duplicated ioctl entries in compat_ioctl.c
2007-07-09 10:54 [PATCH] remove duplicated ioctl entries in compat_ioctl.c Masakazu Mokuno
2007-07-09 11:10 ` Holger Schurig
@ 2007-07-09 11:13 ` Holger Schurig
2007-07-20 5:04 ` Masakazu Mokuno
2007-07-26 18:50 ` [PATCH] " John W. Linville
3 siblings, 0 replies; 7+ messages in thread
From: Holger Schurig @ 2007-07-09 11:13 UTC (permalink / raw)
To: linux-wireless
Forget my mail, I wasn' seening the tiny C/G difference
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: remove duplicated ioctl entries in compat_ioctl.c
2007-07-09 10:54 [PATCH] remove duplicated ioctl entries in compat_ioctl.c Masakazu Mokuno
2007-07-09 11:10 ` Holger Schurig
2007-07-09 11:13 ` Holger Schurig
@ 2007-07-20 5:04 ` Masakazu Mokuno
2007-07-20 13:12 ` John W. Linville
2007-07-26 18:50 ` [PATCH] " John W. Linville
3 siblings, 1 reply; 7+ messages in thread
From: Masakazu Mokuno @ 2007-07-20 5:04 UTC (permalink / raw)
To: linux-wireless
Hi,
This patch does not look to be applied. Is it better that I would submit
to other place?
regards
On Mon, 09 Jul 2007 19:54:39 +0900
Masakazu Mokuno <mokuno@sm.sony.co.jp> wrote:
> This patch removes some duplicated wireless ioctl entries in the array
> 'struct ioctl_trans ioctl_start[]' of fs/compat_ioctl.c
>
> These entries are registered twice like:
>
> COMPATIBLE_IOCTL(SIOCGIWPRIV)
>
> and
>
> HANDLE_IOCTL(SIOCGIWPRIV, do_wireless_ioctl)
>
>
> Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
> ---
> fs/compat_ioctl.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> --- a/fs/compat_ioctl.c
> +++ b/fs/compat_ioctl.c
> @@ -3156,12 +3156,9 @@ COMPATIBLE_IOCTL(SIOCSIWSENS)
> COMPATIBLE_IOCTL(SIOCGIWSENS)
> COMPATIBLE_IOCTL(SIOCSIWRANGE)
> COMPATIBLE_IOCTL(SIOCSIWPRIV)
> -COMPATIBLE_IOCTL(SIOCGIWPRIV)
> COMPATIBLE_IOCTL(SIOCSIWSTATS)
> -COMPATIBLE_IOCTL(SIOCGIWSTATS)
> COMPATIBLE_IOCTL(SIOCSIWAP)
> COMPATIBLE_IOCTL(SIOCGIWAP)
> -COMPATIBLE_IOCTL(SIOCSIWSCAN)
> COMPATIBLE_IOCTL(SIOCSIWRATE)
> COMPATIBLE_IOCTL(SIOCGIWRATE)
> COMPATIBLE_IOCTL(SIOCSIWRTS)
>
>
> --
> Masakazu MOKUNO
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Masakazu MOKUNO
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: remove duplicated ioctl entries in compat_ioctl.c
2007-07-20 5:04 ` Masakazu Mokuno
@ 2007-07-20 13:12 ` John W. Linville
0 siblings, 0 replies; 7+ messages in thread
From: John W. Linville @ 2007-07-20 13:12 UTC (permalink / raw)
To: Masakazu Mokuno; +Cc: linux-wireless
On Fri, Jul 20, 2007 at 02:04:29PM +0900, Masakazu Mokuno wrote:
> Hi,
>
> This patch does not look to be applied. Is it better that I would submit
> to other place?
No, this is the right place. I've got the patch. I just had a lot
of other patches to process, and this one didn't seem to be urgent.
John
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] remove duplicated ioctl entries in compat_ioctl.c
2007-07-09 10:54 [PATCH] remove duplicated ioctl entries in compat_ioctl.c Masakazu Mokuno
` (2 preceding siblings ...)
2007-07-20 5:04 ` Masakazu Mokuno
@ 2007-07-26 18:50 ` John W. Linville
2007-07-27 1:35 ` Masakazu Mokuno
3 siblings, 1 reply; 7+ messages in thread
From: John W. Linville @ 2007-07-26 18:50 UTC (permalink / raw)
To: Masakazu Mokuno; +Cc: linux-wireless, Geert Uytterhoeven, geoffrey.levand
On Mon, Jul 09, 2007 at 07:54:39PM +0900, Masakazu Mokuno wrote:
> This patch removes some duplicated wireless ioctl entries in the array
> 'struct ioctl_trans ioctl_start[]' of fs/compat_ioctl.c
>
> These entries are registered twice like:
>
> COMPATIBLE_IOCTL(SIOCGIWPRIV)
>
> and
>
> HANDLE_IOCTL(SIOCGIWPRIV, do_wireless_ioctl)
>
>
> Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
> ---
> fs/compat_ioctl.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> --- a/fs/compat_ioctl.c
> +++ b/fs/compat_ioctl.c
> @@ -3156,12 +3156,9 @@ COMPATIBLE_IOCTL(SIOCSIWSENS)
> COMPATIBLE_IOCTL(SIOCGIWSENS)
> COMPATIBLE_IOCTL(SIOCSIWRANGE)
> COMPATIBLE_IOCTL(SIOCSIWPRIV)
> -COMPATIBLE_IOCTL(SIOCGIWPRIV)
> COMPATIBLE_IOCTL(SIOCSIWSTATS)
> -COMPATIBLE_IOCTL(SIOCGIWSTATS)
> COMPATIBLE_IOCTL(SIOCSIWAP)
> COMPATIBLE_IOCTL(SIOCGIWAP)
> -COMPATIBLE_IOCTL(SIOCSIWSCAN)
> COMPATIBLE_IOCTL(SIOCSIWRATE)
> COMPATIBLE_IOCTL(SIOCGIWRATE)
> COMPATIBLE_IOCTL(SIOCSIWRTS)
As I read the code in compat_ioctl.c, it looks to me like the
COMPATIBLE_IOCTL definitions are the ones that are actually being
used today. Do you agree?
Given the...stability...of the wireless extensions API, if we are going
to remove one or the other of these not-quite-duplicate definitions,
shouldn't we remove the HANDLE_IOCTL defintions instead?
John
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] remove duplicated ioctl entries in compat_ioctl.c
2007-07-26 18:50 ` [PATCH] " John W. Linville
@ 2007-07-27 1:35 ` Masakazu Mokuno
0 siblings, 0 replies; 7+ messages in thread
From: Masakazu Mokuno @ 2007-07-27 1:35 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, Geert Uytterhoeven, geoffrey.levand
On Thu, 26 Jul 2007 14:50:29 -0400
"John W. Linville" <linville@tuxdriver.com> wrote:
> On Mon, Jul 09, 2007 at 07:54:39PM +0900, Masakazu Mokuno wrote:
> > This patch removes some duplicated wireless ioctl entries in the array
> > 'struct ioctl_trans ioctl_start[]' of fs/compat_ioctl.c
> >
> > These entries are registered twice like:
> >
> > COMPATIBLE_IOCTL(SIOCGIWPRIV)
> >
> > and
> >
> > HANDLE_IOCTL(SIOCGIWPRIV, do_wireless_ioctl)
> >
> >
> > Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
> > ---
> > fs/compat_ioctl.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > --- a/fs/compat_ioctl.c
> > +++ b/fs/compat_ioctl.c
> > @@ -3156,12 +3156,9 @@ COMPATIBLE_IOCTL(SIOCSIWSENS)
> > COMPATIBLE_IOCTL(SIOCGIWSENS)
> > COMPATIBLE_IOCTL(SIOCSIWRANGE)
> > COMPATIBLE_IOCTL(SIOCSIWPRIV)
> > -COMPATIBLE_IOCTL(SIOCGIWPRIV)
> > COMPATIBLE_IOCTL(SIOCSIWSTATS)
> > -COMPATIBLE_IOCTL(SIOCGIWSTATS)
> > COMPATIBLE_IOCTL(SIOCSIWAP)
> > COMPATIBLE_IOCTL(SIOCGIWAP)
> > -COMPATIBLE_IOCTL(SIOCSIWSCAN)
> > COMPATIBLE_IOCTL(SIOCSIWRATE)
> > COMPATIBLE_IOCTL(SIOCGIWRATE)
> > COMPATIBLE_IOCTL(SIOCSIWRTS)
>
> As I read the code in compat_ioctl.c, it looks to me like the
> COMPATIBLE_IOCTL definitions are the ones that are actually being
> used today. Do you agree?
Yes. The latter one in the array is silently ignored. In our case,
HANDLE_IOCTL(SIOCGIWPRIV, do_wireless_ioctl) ignored.
> Given the...stability...of the wireless extensions API, if we are going
> to remove one or the other of these not-quite-duplicate definitions,
> shouldn't we remove the HANDLE_IOCTL defintions instead?
I'm not sure which is better to keep.
We can keep COMPATIBLE_IOCTL entries if the userland apps could work
around iw_point.pointer issue for these ioctls.
--
Masakazu MOKUNO
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-07-27 1:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-09 10:54 [PATCH] remove duplicated ioctl entries in compat_ioctl.c Masakazu Mokuno
2007-07-09 11:10 ` Holger Schurig
2007-07-09 11:13 ` Holger Schurig
2007-07-20 5:04 ` Masakazu Mokuno
2007-07-20 13:12 ` John W. Linville
2007-07-26 18:50 ` [PATCH] " John W. Linville
2007-07-27 1:35 ` Masakazu Mokuno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).