From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Michael Buesch <mb@bu3sch.de>,
Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] bcm43xx-mac80211: Fix specs typo for baseband attenuation
Date: Thu, 26 Jul 2007 13:21:38 -0400 [thread overview]
Message-ID: <20070726172138.GA6068@tuxdriver.com> (raw)
In-Reply-To: <46a8ccbd.wNQamvQ9e0RJ0XZK%Larry.Finger@lwfinger.net>
On Thu, Jul 26, 2007 at 11:33:01AM -0500, Larry Finger wrote:
> A typo in the specs interchanges the branches in an if statement, which
> breaks operations for a BCM4306/rev 2 that has phy->analog == 1.
> @@ -1895,7 +1895,7 @@ void bcm43xx_phy_set_baseband_attenuatio
> bcm43xx_write16(dev, BCM43xx_MMIO_PHY0,
> (bcm43xx_read16(dev, BCM43xx_MMIO_PHY0)
> & 0xFFF0) | baseband_attenuation);
> - } else if (phy->analog == 1) {
> + } else if (phy->analog != 1) {
> bcm43xx_phy_write(dev, BCM43xx_PHY_DACCTL,
> (bcm43xx_phy_read(dev, BCM43xx_PHY_DACCTL)
> & 0xFFC3) | (baseband_attenuation << 2));
Larry,
How does this relate to the bcm43xx patch you asked me to revert
(and has been reverted in F-7)? That one change "==" to ">", while
this one changes "==" to "!=". Instead of reverting the other,
should it do the same thing as this?
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-07-26 17:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 16:33 [PATCH] bcm43xx-mac80211: Fix specs typo for baseband attenuation Larry Finger
2007-07-26 17:21 ` John W. Linville [this message]
2007-07-26 17:56 ` Larry Finger
2007-07-26 18:13 ` John W. Linville
2007-07-26 18:49 ` Larry Finger
2007-07-26 19:26 ` John W. Linville
2007-07-26 19:38 ` Michael Buesch
2007-07-27 9:18 ` David Woodhouse
2007-07-27 9:20 ` Michael Buesch
2007-07-29 11:59 ` Paul TBBle Hampson
2007-07-29 12:38 ` Michael Buesch
2007-07-26 17:31 ` Michael Buesch
2007-07-26 18:03 ` Larry Finger
2007-07-26 18:11 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070726172138.GA6068@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).