From: Michael Buesch <mb@bu3sch.de>
To: "Tomas Winkler" <tomasw@gmail.com>
Cc: "Zhu Yi" <yi.zhu@intel.com>,
linville@tuxdriver.com, ipwpatch@vger.kernel.org,
linux-wireless@vger.kernel.org,
"Gregory Greenman" <gregory.greenman@intel.com>
Subject: Re: [PATCH 09/17] iwlwifi: EEPROM reading fix
Date: Sat, 28 Jul 2007 00:32:40 +0200 [thread overview]
Message-ID: <200707280032.40475.mb@bu3sch.de> (raw)
In-Reply-To: <1ba2fa240707271524i591ed932jd3f2998ba6203ad8@mail.gmail.com>
On Saturday 28 July 2007 00:24:42 Tomas Winkler wrote:
> On 7/27/07, Michael Buesch <mb@bu3sch.de> wrote:
> > On Friday 27 July 2007 11:26:33 Zhu Yi wrote:
> > > if (!(r & 1)) {
> > > IWL_ERROR("Time out reading EEPROM[%d]", addr);
> > > - return -ETIMEDOUT;
> > > + rc = -ETIMEDOUT;
> > > + goto done;
> > > }
> > >
> > > e[addr / 2] = le16_to_cpu(r >> 16);
> >
> > Seems like you really want cpu_to_le16() here, as "r" should better
> > be CPU-endian when shifting it by >>.
> >
> > Though, I don't see enough code context here to judge if the
> > endianess conversion is correct at all or not.
> >
> This line is empirically correct.
No, you need cpu_to_le16 here, instead of le16_to_cpu.
I know that these generate the same code, but it makes
a difference for sparse.
--
Greetings Michael.
next prev parent reply other threads:[~2007-07-27 22:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11855284012123-git-send-email-yi.zhu@intel.com>
2007-07-27 9:26 ` [PATCH 01/17] iwlwifi: provide frequency to radiotap monitor not channel index Zhu Yi
2007-07-27 9:26 ` [PATCH 02/17] iwlwifi: Calculate and report noise level while associated Zhu Yi
2007-07-27 9:26 ` [PATCH 03/17] iwlwifi: modify station fix Zhu Yi
2007-07-27 9:26 ` [PATCH 04/17] iwlwifi: cleanup tx queue allocation Zhu Yi
2007-07-27 9:26 ` [PATCH 05/17] iwlwifi: rxon filter_flags endianity fix Zhu Yi
2007-07-27 9:26 ` [PATCH 06/17] iwlwifi: rename base.c to iwl-base.c Zhu Yi
2007-07-27 9:26 ` [PATCH 07/17] iwilwifi: removed unused constant Zhu Yi
2007-07-27 9:26 ` [PATCH 08/17] iwlwifi: QoS control endianity fixes Zhu Yi
2007-07-27 9:26 ` [PATCH 09/17] iwlwifi: EEPROM reading fix Zhu Yi
2007-07-27 9:26 ` [PATCH 10/17] iwlwifi: endianity cleaning of iwl_print_rx_config_cmd Zhu Yi
2007-07-27 9:26 ` [PATCH 11/17] iwlwifi: endianity cleanup for QoS host command Zhu Yi
2007-07-27 9:26 ` [PATCH 12/17] iwlwifi: endianity cleanup for power table " Zhu Yi
2007-07-27 9:26 ` [PATCH 13/17] iwlwifi: fix 11n on 2.4 channel Zhu Yi
2007-07-27 9:26 ` [PATCH 14/17] iwlwifi: fix channel switch assert Zhu Yi
2007-07-27 9:26 ` [PATCH 15/17] iwlwifi: fix scaing watchdog time out Zhu Yi
2007-07-27 9:26 ` [PATCH 16/17] iwlwifi: Add uCode/driver compatibility version number Zhu Yi
2007-07-27 9:26 ` [PATCH 17/17] iwlwifi: update version stamp to 0.1.5 Zhu Yi
2007-07-27 11:22 ` [PATCH 09/17] iwlwifi: EEPROM reading fix Michael Buesch
2007-07-27 22:24 ` Tomas Winkler
2007-07-27 22:32 ` Michael Buesch [this message]
2007-07-27 9:30 ` [PATCH 00/17] iwlwifi driver updated to version 0.1.5 Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707280032.40475.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=gregory.greenman@intel.com \
--cc=ipwpatch@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomasw@gmail.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).