From: Randy Dunlap <randy.dunlap@oracle.com>
To: Satyam Sharma <satyam@infradead.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Matthias Kaehlcke <matthias.kaehlcke@gmail.com>,
Michael Buesch <mb@bu3sch.de>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
Date: Mon, 30 Jul 2007 13:13:02 -0700 [thread overview]
Message-ID: <20070730131302.82622b06.randy.dunlap@oracle.com> (raw)
In-Reply-To: <alpine.LFD.0.999.0707310142190.17287@enigma.security.iitk.ac.in>
On Tue, 31 Jul 2007 01:44:37 +0530 (IST) Satyam Sharma wrote:
>
>
> On Mon, 30 Jul 2007, John W. Linville wrote:
>
> > On Mon, Jul 30, 2007 at 12:50:31PM +0530, Satyam Sharma wrote:
> > > On Mon, 30 Jul 2007, Matthias Kaehlcke wrote:
> > >
> > > > [...]
> > > > The Host AP driver uses a semaphore as mutex. Use the mutex API
> > > > instead of the (binary) semaphore.
> > > >
> > > > Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
> > >
> > > Reviewed-by: Satyam Sharma <satyam@infradead.org>
> >
> > Is that the same as Acked-by? Or do you disagree with the patch?
> >
> > Just checkin'...
>
> Well, I'm not the maintainer, so didn't think correct to give an
> "Acked-by". "Reviewed-by" generally means I read the patch, and think
> it is correct. Probably could save time for others ...
You should use Acked-by. See Documentation/SubmittingPatches. :)
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-07-30 20:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070729212909.GC3432@traven>
2007-07-29 21:34 ` [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver Matthias Kaehlcke
2007-07-29 22:06 ` Michael Buesch
2007-07-30 3:18 ` Satyam Sharma
2007-07-30 3:47 ` Satyam Sharma
2007-07-30 5:40 ` Matthias Kaehlcke
2007-07-30 7:20 ` Satyam Sharma
2007-07-30 14:50 ` John W. Linville
2007-07-30 20:14 ` Satyam Sharma
2007-07-30 20:13 ` Randy Dunlap [this message]
2007-07-30 17:09 ` Michael Buesch
2007-07-30 19:23 ` Andrew Morton
2007-07-30 20:11 ` Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730131302.82622b06.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=matthias.kaehlcke@gmail.com \
--cc=mb@bu3sch.de \
--cc=satyam@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).