linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Cc: linux-wireless@vger.kernel.org, jt@hpl.hp.com
Subject: Re: [PATCH] remove duplicated ioctl entries in compat_ioctl.c
Date: Mon, 30 Jul 2007 10:47:26 -0400	[thread overview]
Message-ID: <20070730144726.GA6586@tuxdriver.com> (raw)
In-Reply-To: <20070730145358.327D.MOKUNO@sm.sony.co.jp>

On Mon, Jul 30, 2007 at 09:02:56PM +0900, Masakazu Mokuno wrote:

> In second half of the mail, I understood the he asked how about keeping
> used one (COMPATIBLE_IOCTL) instead of HANDLE_IOCTL one, considering
> compatibilities.  As I can esteem the idea that sometimes the compatibilities
> are more important than changing something and I didn't think my patch
> could address all problems of the issue and I had much time to test more,
> I replied with the intention that I didn't stick to the patch if all
> userland application could work around perfectly.

Masakazu-san,

Thank you very much for your thorough explanation of the situation.
I apologize for having been a bit slow to grasp what you were doing.

I agree that the HANDLE_IOCTL version seems correct.  As you correctly
understood, my concern was that we not break anything new in the
process of fixing this bug.

Have you tested the both the old and the new wireless-tools on
a kernel with your patch applied?  Both 32- and 64-bit versions?
Do they all work equally well?

Thanks,

John
-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2007-07-30 17:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-27 17:13 Re: [PATCH] remove duplicated ioctl entries in compat_ioctl.c Jean Tourrilhes
2007-07-27 19:10 ` John W. Linville
2007-07-27 21:58   ` Jean Tourrilhes
2007-07-30 12:02     ` Masakazu Mokuno
2007-07-30 14:47       ` John W. Linville [this message]
2007-07-30 18:37         ` Jean Tourrilhes
2007-07-31  4:45           ` Masakazu Mokuno
2007-07-31 16:55             ` Jean Tourrilhes
2007-08-07  7:41         ` Masakazu Mokuno
2007-08-07 17:51           ` Jean Tourrilhes
2007-09-12  4:36           ` Masakazu Mokuno
2007-09-12 13:43             ` John W. Linville
  -- strict thread matches above, loose matches on Subject: below --
2007-07-09 10:54 Masakazu Mokuno
2007-07-09 11:10 ` Holger Schurig
2007-07-09 11:13 ` Holger Schurig
2007-07-26 18:50 ` John W. Linville
2007-07-27  1:35   ` Masakazu Mokuno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070730144726.GA6586@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=jt@hpl.hp.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mokuno@sm.sony.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).