Re: [PATCH] zd1211rw-mac80211: debug output for mac80211 ops

[Michael Wu <flamingice@sourmilk.net>]

[-- Attachment #1: Type: text/plain, Size: 1852 bytes --]

On Monday 30 July 2007 15:52, Ulrich Kunitz wrote:
> John W. Linville wrote:
> > On Sun, Jul 29, 2007 at 08:21:31PM -0700, Michael Wu wrote:
> > > On Sunday 29 July 2007 19:31, Daniel Drake wrote:
> > > > This patch adds debug output to mac80211 operations. This is
> > > > intended to sort out the issues with the interface semantics.
> > >
> > > Ugh. I really hate enter/exit and especially these since they are open
> > > coded. What do you need clarified about mac80211 interface semantics?
> >
> > I agree, these are a bit ugly.  Do you intend them to be permanent?
>
> Guys, actually I looked into iwl-base.c and there are also leave
> and enter statements for exactly the same mac80211 operations. I
> would appreciate, if somebody could explain me the difference.
>
None. I didn't like the ones in iwlwifi either.

> Please notify that the messages will only be compiled into the
> driver if ZD1211_DEBUG is set. I could agree to take them out,
> after we have fixed the multiple interface issues, but right now
> they help to make the logfile quite readable. They help also to
> check my understanding of the struct ieee80211_ops functions.
>
I would prefer if you kept it in your tree.

> Asked what I don't understand about the mac80211 interfaces, I
> have following questions:
>
> Why does WIPHY has only a single MAC address?
>
That is for the mac address stored in the eeprom.

> Though ZD1211 has only one RF chip and one baseband processor --
> which represents a single PHY device in my opinion -- it can
> support two MAC addresses. Sure MAC80211 can give different IP
> addresses to different interfaces, but currently I'm not sure, how
> they relate to the address in the WIPHY.
>
The proper address to use is given in add_interface. Don't worry about the 
address in wiphy.

-Michael Wu

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]