Re: [PATCH 4/7] iwlwifi: Endainity fix for rx configuration

[Michael Buesch <mb@bu3sch.de>]

On Tuesday 31 July 2007, Zhu Yi wrote:
> From: Tomas Winkler <tomas.winkler@intel.com>
> 
> This patch fixes endianity issues in rx configuration
> related code.
> 
> Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Zhu Yi <yi.zhu@intel.com>
> ---
>  drivers/net/wireless/iwl-4965.c |   26 ++++---
>  drivers/net/wireless/iwl-base.c |  148 +++++++++++++++++++++------------------
>  drivers/net/wireless/iwl-hw.h   |   10 ++--
>  3 files changed, 101 insertions(+), 83 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwl-4965.c b/drivers/net/wireless/iwl-4965.c
> index 19591a6..786c5d0 100644
> --- a/drivers/net/wireless/iwl-4965.c
> +++ b/drivers/net/wireless/iwl-4965.c
> @@ -3615,8 +3615,8 @@ static void iwl4965_handle_data_packet(struct iwl_priv *priv, int is_data,
>  
>  		hdr = (void *)(pkt->u.raw +
>  			       sizeof(struct iwl4965_rx_mpdu_res_start));
> -		rx_end = (u32 *) (((u8 *) hdr) + amsdu->byte_count);
>  		len = amsdu->byte_count;
> +		rx_end = (u32 *) (((u8 *) hdr) + len);

I doubt rx_end is a pointer to u32. Most likely you want to use
(__le32 *) here and also audit the users of rx_end, if they
need le32_to_cpu().