linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, rt2400-devel@lists.sourceforge.net
Subject: [PATCH 01/24] rt2x00: Remove rt73usb_get_tsf
Date: Tue, 31 Jul 2007 20:36:55 +0200	[thread overview]
Message-ID: <200707312036.55850.IvDoorn@gmail.com> (raw)

>From 23d440a413208983ed8b17ac7048516f8bb9ed74 Mon Sep 17 00:00:00 2001
From: Ivo van Doorn <IvDoorn@gmail.com>
Date: Fri, 27 Jul 2007 13:58:18 +0200
Subject: [PATCH 01/24] rt2x00: Remove rt73usb_get_tsf

The get_tsf function must be atomic according to mac80211,
this means that rt73usb is not capable of supporting this feature
since all USB register access functions require sleeping.
Place rt73usb_get_tsf between #if 0 statements to disable it,
so that it can be easily readded when the atomic requirement
has been removed.

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
 drivers/net/wireless/rt73usb.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/rt73usb.c b/drivers/net/wireless/rt73usb.c
index 3d838d1..bc9b56c 100644
--- a/drivers/net/wireless/rt73usb.c
+++ b/drivers/net/wireless/rt73usb.c
@@ -1723,6 +1723,13 @@ static int rt73usb_set_retry_limit(struct ieee80211_hw *hw,
 	return 0;
 }
 
+#if 0
+/*
+ * Mac80211 demands get_tsf must be atomic.
+ * This is not possible for rt73usb since all register access
+ * functions require sleeping. Untill mac80211 no longer needs
+ * get_tsf to be atomic, this function should be disabled.
+ */
 static u64 rt73usb_get_tsf(struct ieee80211_hw *hw)
 {
 	struct rt2x00_dev *rt2x00dev = hw->priv;
@@ -1736,6 +1743,7 @@ static u64 rt73usb_get_tsf(struct ieee80211_hw *hw)
 
 	return tsf;
 }
+#endif
 
 static void rt73usb_reset_tsf(struct ieee80211_hw *hw)
 {
@@ -1757,7 +1765,12 @@ static const struct ieee80211_ops rt73usb_mac80211_ops = {
 	.set_retry_limit	= rt73usb_set_retry_limit,
 	.conf_tx		= rt2x00lib_conf_tx,
 	.get_tx_stats		= rt2x00lib_get_tx_stats,
+#if 0
+/*
+ * See comment at the rt73usb_get_tsf function.
+ */
 	.get_tsf		= rt73usb_get_tsf,
+#endif
 	.reset_tsf		= rt73usb_reset_tsf,
 	.beacon_update		= rt2x00usb_beacon_update,
 };
-- 
1.5.2.4


                 reply	other threads:[~2007-07-31 18:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200707312036.55850.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=rt2400-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).