Re: [PATCH] zd1211rw-mac80211: debug output for mac80211 ops

[Michael Buesch <mb@bu3sch.de>]

On Tuesday 31 July 2007 23:06:13 Jiri Benc wrote:
> On Mon, 30 Jul 2007 22:22:58 -0700, Michael Wu wrote:
> > On Monday 30 July 2007 16:05, Michael Buesch wrote:
> > > I suggest you look at bcm43xx-mac80211.
> > > You will need to introduce refcounting for your monitor interfaces
> > > and I _really_ suggest to get rid of the zd_op_open() and zd_op_close()
> > > functions. Just include that in add/remove interface. You need
> > > to refcount your interfaces anyway.
> > >
> > Requiring refcounting for monitor interfaces is fairly dumb since mac80211 
> > does the exact same refcounting. I haven't bothered to do it in any driver 
> > ports yet for this reason. This part of the mac80211 driver api needs to be 
> > fixed.
> 
> Ouch, I thought we don't bother drivers with more than one monitor
> interface at a time. Apparently I forgot to fix that.
> 
> > Also, I'm not entirely convinced that eliminating the open/close callbacks is 
> > a good idea,
> 
> Why?

Yeah, I don't see the need for open/close, either.
We can live perfectly well without them. It even reduces code complexity
and makes drivers more readable.
In add/remove you better know anyway, if the interface is up or down.
So if it's down in add_interface, just init it. It's a matter of an if statement.
Really nothing more.

-- 
Greetings Michael.