From: Michael Buesch <mb@bu3sch.de>
To: bcm43xx-dev@lists.berlios.de
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [RFC V2] bcm43xx-mac80211: Provide information to allow transmission rate decreases
Date: Thu, 2 Aug 2007 15:03:53 +0200 [thread overview]
Message-ID: <200708021503.53982.mb@bu3sch.de> (raw)
In-Reply-To: <1186055319.24230.32.camel@johannes.berg>
On Thursday 02 August 2007 13:48:39 Johannes Berg wrote:
> On Thu, 2007-08-02 at 13:37 +0200, Michael Buesch wrote:
>
> > If we just check the ack bit, rate control would throttle, just because
> > we sent unacked frames.
>
> Ah but rate control shouldn't actually care about frames that we never
> expected an ACK for since there's no way to know for those anyway. So
> IMHO the rate control algorithm shouldn't even be called for those
> frames.
>
> > So if we didn't get an ack, we need to check if we failed, or if...
> > Oh, acutally. Why not simply check the noack bit in the tx_control... :)
>
> Works too, but it seems mac80211 should do that.
So, what's the point of this "excessive retries" field anyway?
We already have an "acked" bit. So if it's not set, but we expected an
ack, what's the point of setting excessive retries in the driver?
the rc algo sould know _anyway_, as it has the "acked" and the
"we wanted to have an ack" bits.
confused..
--
Greetings Michael.
next prev parent reply other threads:[~2007-08-02 13:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 20:56 [RFC V2] bcm43xx-mac80211: Provide information to allow transmission rate decreases Larry Finger
2007-08-01 22:14 ` Michael Buesch
2007-08-02 9:09 ` Johannes Berg
2007-08-02 11:11 ` Michael Buesch
2007-08-02 11:18 ` Johannes Berg
2007-08-02 11:37 ` Michael Buesch
2007-08-02 11:48 ` Johannes Berg
2007-08-02 13:03 ` Michael Buesch [this message]
2007-08-02 13:07 ` Johannes Berg
2007-08-02 15:02 ` Larry Finger
2007-08-03 9:40 ` Johannes Berg
2007-08-01 22:48 ` rob m
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708021503.53982.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).