From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: stable@kernel.org, John Linville <linville@tuxdriver.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH stable] softmac: Fix deadlock of wx_set_essid with assoc work
Date: Fri, 3 Aug 2007 12:50:50 +0200 [thread overview]
Message-ID: <200708031250.51161.mb@bu3sch.de> (raw)
In-Reply-To: <1186092127.4647.10.camel@johannes.berg>
On Friday 03 August 2007 00:02:07 Johannes Berg wrote:
> Adding to my previous mail, this fix is not enough. As you can see
> below, it is never safe to call flush_scheduled_work() under rtnl
> because some other things running *from* the global events workqueue
> acquire the rtnl and hence it we could deadlock against them.
>
> I think the fix would be to use cancel_delayed_work_sync() here instead
> of a combination of cancel_delayed_work() and flush_workqueue().
Ah, Ok. I didn't see that rtnl is locked there, too.
cancel_delayed_work_sync could probably work. Care to test that?
--
Greetings Michael.
next prev parent reply other threads:[~2007-08-03 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 10:53 [PATCH stable] softmac: Fix deadlock of wx_set_essid with assoc work Michael Buesch
2007-08-02 21:55 ` Johannes Berg
2007-08-02 22:02 ` Johannes Berg
2007-08-03 10:50 ` Michael Buesch [this message]
2007-08-03 14:49 ` Johannes Berg
2007-08-06 14:23 ` Johannes Berg
2007-08-07 9:57 ` Michael Buesch
2007-08-07 10:10 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708031250.51161.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=dwmw2@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).